Bug 80064 - [chromium] Fix errors in LayerRendererChromium cleanup
Summary: [chromium] Fix errors in LayerRendererChromium cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-01 16:09 PST by Kenneth Russell
Modified: 2012-03-02 01:13 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.18 KB, patch)
2012-03-01 16:11 PST, Kenneth Russell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2012-03-01 16:09:02 PST
LayerRendererChromium's cleanup path doesn't match the declaration order of the OwnPtrs to ProgramBindings in its header, and there are consequently a couple of objects which aren't getting cleaned up properly. This is leading to assertion failures during lost context operations and interfering with the investigation of http://crbug.com/113125 .
Comment 1 Kenneth Russell 2012-03-01 16:11:19 PST
Created attachment 129766 [details]
Patch
Comment 2 James Robinson 2012-03-01 16:14:18 PST
Comment on attachment 129766 [details]
Patch

R=me. This code has gotten smelly :(
Comment 3 WebKit Review Bot 2012-03-02 01:13:03 PST
Comment on attachment 129766 [details]
Patch

Clearing flags on attachment: 129766

Committed r109528: <http://trac.webkit.org/changeset/109528>
Comment 4 WebKit Review Bot 2012-03-02 01:13:15 PST
All reviewed patches have been landed.  Closing bug.