RESOLVED FIXED 80057
[chromium] Pass WebNavigationPolicy to WebViewClient::createView 
https://bugs.webkit.org/show_bug.cgi?id=80057
Summary [chromium] Pass WebNavigationPolicy to WebViewClient::createView
Charles Reis
Reported 2012-03-01 15:19:45 PST
For the Chromium port, we would like to know the window disposition (e.g., background/foreground tab/window) inside WebViewClient::createView. Chromium's WebNavigationPolicy enum tracks the window disposition, and it is currently stored as a member of FrameLoaderClientImpl from dispatchDecidePolicyForNewWindowAction until dispatchCreatePage, where it gets passed to WebViewImpl for use in show. To make it available to createView, we also need to change dispatchCreatePage to give it to ChromeClientImpl. This is useful for opening new window navigations in a new process, as part of http://crbug.com/69267.
Attachments
Patch (6.81 KB, patch)
2012-03-01 15:25 PST, Charles Reis 		no flags
DetailsFormatted DiffDiff
Patch (11.58 KB, patch)
2012-03-02 15:34 PST, Charles Reis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Charles Reis
Comment 1 2012-03-01 15:25:01 PST
Created attachment 129757 [details] Patch
Build Bot
Comment 2 2012-03-01 15:43:28 PST
Comment on attachment 129757 [details] Patch Attachment 129757 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/11767628
Charles Reis
Comment 3 2012-03-01 15:50:11 PST
Note: the current patch isn't quite right yet, but it shows the general intent. There are some paths we can take to ChromeClientImpl::createWindow without going through FrameLoaderClientImpl::dispatchCreatePage, in which case we don't set the WebNavigationPolicy first. As a result, we fail the assert.
Darin Fisher (:fishd, Google)
Comment 4 2012-03-02 15:07:05 PST
Comment on attachment 129757 [details] Patch This is what I was expecting...
Charles Reis
Comment 5 2012-03-02 15:34:32 PST
Created attachment 129966 [details] Patch
WebKit Review Bot
Comment 6 2012-03-02 15:36:44 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Darin Fisher (:fishd, Google)
Comment 7 2012-03-02 15:38:14 PST
Comment on attachment 129966 [details] Patch That makes sense. R=me
WebKit Review Bot
Comment 8 2012-03-05 11:50:23 PST
Comment on attachment 129966 [details] Patch Clearing flags on attachment: 129966 Committed r109778: <http://trac.webkit.org/changeset/109778>
WebKit Review Bot
Comment 9 2012-03-05 11:50:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.