Bug 80051 - Update usage of LayoutUnits in InlineBox and InlineFlowBox
Summary: Update usage of LayoutUnits in InlineBox and InlineFlowBox
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
Depends on:
Blocks: 60318
  Show dependency treegraph
Reported: 2012-03-01 14:33 PST by Levi Weintraub
Modified: 2012-03-07 11:00 PST (History)
5 users (show)

See Also:

Patch (10.44 KB, patch)
2012-03-05 11:43 PST, Levi Weintraub
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-03-01 14:33:00 PST
Updating InlineFlowBox to match LayoutUnit usage in the subpixellayout branch.
Comment 1 Levi Weintraub 2012-03-05 11:43:05 PST
Created attachment 130168 [details]
Comment 2 Eric Seidel (no email) 2012-03-06 17:08:11 PST
Comment on attachment 130168 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=130168&action=review

Looks OK.

> Source/WebCore/ChangeLog:8
> +        Updating LayoutUnit vs Integer usage in InlineBox and InlineFlowBox.

Please explain why.   I guess you did some in the individual changes below...  You could even link to your fancy wiki. :)  "Although the LineBox tree uses floats internally, borders/padding are caulated with LayoutUnits, like the rest of block layout in the rendering tree.  See the wiki *URL* for more details."
Comment 3 Levi Weintraub 2012-03-07 10:59:52 PST
Committed r110070: <http://trac.webkit.org/changeset/110070>