Bug 80033 - WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
Summary: WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-01 09:37 PST by Kalev Lember
Modified: 2012-03-01 22:26 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.65 KB, patch)
2012-03-01 09:40 PST, Kalev Lember 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kalev Lember 2012-03-01 09:37:24 PST 
WebKitTestRunner/TestInvocation.cpp uses getcwd(), but only includes the unistd.h header for Mac. This worked fine in the past because gcc < 4.7 included unistd.h from standard C++ library headers. However, this is no longer the case with gcc 4.7 and we need to explicitly include unistd.h.
Comment 1 Kalev Lember 2012-03-01 09:40:54 PST 
Created attachment 129717 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-01 22:26:24 PST 
Comment on attachment 129717 [details]
Patch

Clearing flags on attachment: 129717

Committed r109509: <http://trac.webkit.org/changeset/109509>
Comment 3 WebKit Review Bot 2012-03-01 22:26:27 PST 
All reviewed patches have been landed.  Closing bug.