Bug 80031 - [GTK] Parts of WebKitTestRunner are getting built even if WK2 is disabled
Summary: [GTK] Parts of WebKitTestRunner are getting built even if WK2 is disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-01 09:23 PST by Kalev Lember
Modified: 2012-03-01 12:38 PST (History)
1 user (show)

See Also:


Attachments
Patch (1.66 KB, patch)
2012-03-01 09:26 PST, Kalev Lember
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kalev Lember 2012-03-01 09:23:41 PST
The libTestRunnerInjectedBundle.la convencience library is missing a guard to avoid building it when WebKit2GTK+ is disabled. This isn't much of a problem on Linux, but breaks build for Windows where WK2 doesn't (yet) build properly.
Comment 1 Kalev Lember 2012-03-01 09:26:17 PST
Created attachment 129714 [details]
Patch
Comment 2 WebKit Review Bot 2012-03-01 12:38:07 PST
Comment on attachment 129714 [details]
Patch

Clearing flags on attachment: 129714

Committed r109396: <http://trac.webkit.org/changeset/109396>
Comment 3 WebKit Review Bot 2012-03-01 12:38:11 PST
All reviewed patches have been landed.  Closing bug.