Bug 80026 - [EFL] Prefix run-launcher with run-with-jhbuild
Summary: [EFL] Prefix run-launcher with run-with-jhbuild
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Dominik Röttsches (drott)
URL:
Keywords:
Depends on: 79673
Blocks: 79480
  Show dependency tree / graph
 
Reported: 2012-03-01 07:28 PST by Dominik Röttsches (drott)
Modified: 2012-03-19 03:47 PDT (History)
3 users (show)

See Also:

Attachments
Run launcher under jhbuild, v1 (1.36 KB, patch)
2012-03-15 08:25 PDT, Dominik Röttsches (drott) 		no flags Details | Formatted Diff | Diff
Run launcher under jhbuild, v2 (1.12 KB, patch)
2012-03-16 07:37 PDT, Dominik Röttsches (drott) 		pnormand: review+
Details | Formatted Diff | Diff
Run launcher under jhbuild, v3 (1003 bytes, patch)
2012-03-19 02:38 PDT, Dominik Röttsches (drott) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Röttsches (drott) 2012-03-01 07:28:03 PST 
In order for the launcher to use the jhbuild-provided EFL libaries, let's prefix it with run-with-jhbuild as well.
Comment 1 Dominik Röttsches (drott) 2012-03-15 08:25:48 PDT 
Created attachment 132056 [details]
Run launcher under jhbuild, v1
Comment 2 Dominik Röttsches (drott) 2012-03-16 07:37:50 PDT 
Created attachment 132282 [details]
Run launcher under jhbuild, v2

catfile not required, patch simplified.
Comment 3 Philippe Normand 2012-03-19 02:27:00 PDT 
Comment on attachment 132282 [details]
Run launcher under jhbuild, v2

View in context: https://bugs.webkit.org/attachment.cgi?id=132282&action=review

> Tools/Scripts/run-launcher:77
> +        my $jhbuildWrapper = catdir(sourceDir(), "Tools", "efl", "run-with-jhbuild");
> +        $launcherPath = $jhbuildWrapper;

Maybe this can be one line?

$launcherPath = catdir(sourceDir(), "Tools", "efl", "run-with-jhbuild");
Comment 4 Dominik Röttsches (drott) 2012-03-19 02:38:14 PDT 
Created attachment 132561 [details]
Run launcher under jhbuild, v3

In one line, changelog rebased.
Comment 5 WebKit Review Bot 2012-03-19 03:47:46 PDT 
Comment on attachment 132561 [details]
Run launcher under jhbuild, v3

Clearing flags on attachment: 132561

Committed r111172: <http://trac.webkit.org/changeset/111172>
Comment 6 WebKit Review Bot 2012-03-19 03:47:51 PDT 
All reviewed patches have been landed.  Closing bug.