Bug 80025 - [EFL] Prefixing run-webkit-tests with run-with-jhbuild
Summary: [EFL] Prefixing run-webkit-tests with run-with-jhbuild
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Dominik Röttsches (drott)
URL:
Keywords:
Depends on: 79673
Blocks: 79480
  Show dependency treegraph
 
Reported: 2012-03-01 07:25 PST by Dominik Röttsches (drott)
Modified: 2012-03-17 11:13 PDT (History)
5 users (show)

See Also:


Attachments
Run EFL tests under jhbuild, v1 (1.83 KB, patch)
2012-03-15 08:14 PDT, Dominik Röttsches (drott)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Röttsches (drott) 2012-03-01 07:25:56 PST
Next step for solving 79480, let's change the EFL test execution to be prefixed with run-with-jhbuild.
Comment 1 Dominik Röttsches (drott) 2012-03-15 08:14:42 PDT
Created attachment 132052 [details]
Run EFL tests under jhbuild, v1

Ideally, this should be landed together with bug 79904.
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-03-15 09:19:01 PDT
Comment on attachment 132052 [details]
Run EFL tests under jhbuild, v1

Looks OK.
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-03-17 00:34:12 PDT
Comment on attachment 132052 [details]
Run EFL tests under jhbuild, v1

Clearing flags on attachment: 132052

Committed r111116: <http://trac.webkit.org/changeset/111116>
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-03-17 00:34:19 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Jessie Berlin 2012-03-17 10:24:28 PDT
This caused the python tests to start failing on the Mac bots:

http://build.webkit.org/builders/Lion%20Intel%20Release%20%28Tests%29/builds/6501/steps/webkitpy-test/logs/stdio

All tests pass

http://build.webkit.org/builders/Lion%20Intel%20Release%20%28Tests%29/builds/6502/steps/webkitpy-test/logs/stdio

ERROR: test_driver_cmd_line (webkitpy.layout_tests.port.efl_unittest.EflPortTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Volumes/Data/slave/lion-intel-release-tests/build/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 70, in test_driver_cmd_line
    self.assertTrue(len(port.driver_cmd_line()))
  File "/Volumes/Data/slave/lion-intel-release-tests/build/Tools/Scripts/webkitpy/layout_tests/port/base.py", line 546, in driver_cmd_line
    driver = self.create_driver(0)
  File "/Volumes/Data/slave/lion-intel-release-tests/build/Tools/Scripts/webkitpy/layout_tests/port/base.py", line 754, in create_driver
    return driver.DriverProxy(self, worker_number, self._driver_class(), pixel_tests=self.get_option('pixel_tests'), no_timeout=no_timeout)
  File "/Volumes/Data/slave/lion-intel-release-tests/build/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 186, in __init__
    self._running_drivers[self._cmd_line_as_key(pixel_tests, [])] = self._driver
  File "/Volumes/Data/slave/lion-intel-release-tests/build/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 240, in _cmd_line_as_key
    return ' '.join(self.cmd_line(pixel_tests, per_test_args))
  File "/Volumes/Data/slave/lion-intel-release-tests/build/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 237, in cmd_line
    return self._driver.cmd_line(pixel_tests or self._pixel_tests, per_test_args or [])
TypeError: cmd_line() takes exactly 1 argument (3 given)

----------------------------------------------------------------------
Ran 1313 tests in 15.009s

FAILED (errors=1)

Please fix it, or I will be forced to roll it out.