Bug 80013 - DOMWindow shouldn't have any INDEXED_DATABASE ifdefs
Summary: DOMWindow shouldn't have any INDEXED_DATABASE ifdefs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 79327
  Show dependency treegraph
 
Reported: 2012-03-01 00:38 PST by Adam Barth
Modified: 2012-03-01 12:30 PST (History)
5 users (show)

See Also:


Attachments
Patch (6.90 KB, patch)
2012-03-01 00:41 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-03-01 00:38:11 PST
DOMWindow shouldn't have any INDEXED_DATABASE ifdefs
Comment 1 Adam Barth 2012-03-01 00:41:18 PST
Created attachment 129653 [details]
Patch
Comment 2 Kentaro Hara 2012-03-01 00:52:45 PST
Comment on attachment 129653 [details]
Patch

Looks good
Comment 3 WebKit Review Bot 2012-03-01 00:54:09 PST
Comment on attachment 129653 [details]
Patch

Rejecting attachment 129653 [details] from review queue.

haraken@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 4 Kentaro Hara 2012-03-01 00:55:23 PST
(In reply to comment #3)
> (From update of attachment 129653 [details])
> Rejecting attachment 129653 [details] from review queue.
> 
> haraken@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.
> 
> - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.
> 
> - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

Ah, maybe the svn server is crazy now. I've encountered this before...
Comment 5 Adam Barth 2012-03-01 00:58:28 PST
> Ah, maybe the svn server is crazy now. I've encountered this before...

Yeah, I don't know what's going on.  It doesn't make sense.
Comment 6 Kentaro Hara 2012-03-01 01:08:17 PST
(In reply to comment #5)
> > Ah, maybe the svn server is crazy now. I've encountered this before...
> 
> Yeah, I don't know what's going on.  It doesn't make sense.

Let me r+ it after hours. If you are hurry, please ask another reviewer. When I encountered the issue before, (at least some) other reviewers were able to r+ it.
Comment 7 Adam Barth 2012-03-01 01:13:56 PST
I'm not in a hurry.
Comment 8 WebKit Review Bot 2012-03-01 04:37:47 PST
The commit-queue encountered the following flaky tests while processing attachment 129653 [details]:

perf/object-keys.html bug 63769 (author: ojan@chromium.org)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Review Bot 2012-03-01 04:39:58 PST
Comment on attachment 129653 [details]
Patch

Rejecting attachment 129653 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/11767397
Comment 10 WebKit Review Bot 2012-03-01 04:40:13 PST
Comment on attachment 129653 [details]
Patch

Clearing flags on attachment: 129653

Committed r109336: <http://trac.webkit.org/changeset/109336>
Comment 11 WebKit Review Bot 2012-03-01 04:40:18 PST
All reviewed patches have been landed.  Closing bug.
Comment 12 Kentaro Hara 2012-03-01 04:41:42 PST
Anyway it seems committed successfully.
Comment 13 Adam Klein 2012-03-01 10:13:37 PST
I believe this patch is causing one test to crash:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fdom%2Fremove-body-during-body-replacement2.html&showExpectations=true

The stack trace on Linux/Debug seems quite related:

[4699:4699:16136448032217:ERROR:process_util_posix.cc(142)] Received signal 11
	base::debug::StackTrace::StackTrace() [0x735cbe]
	base::(anonymous namespace)::StackDumpSignalHandler() [0x6ef8a1]
	0x7f0e4fa7caf0
	WTF::HashTable<>::find<>() [0x14223be]
	WTF::HashTable<>::find() [0x142151a]
	WTF::HashSet<>::find() [0x142033a]
	WTF::HashSet<>::remove() [0x141e08d]
	WebCore::DOMWindow::unregisterProperty() [0x14166e2]
	WebCore::DOMWindowProperty::~DOMWindowProperty() [0x14239b2]
	WebCore::DOMWindowIndexedDatabase::~DOMWindowIndexedDatabase() [0x2588eb1]
	WTF::deleteOwnedPtr<>() [0x1421fbd]
	WTF::OwnPtr<>::~OwnPtr() [0x1420e63]
	std::pair<>::~pair() [0x141fba4]
	WTF::HashTable<>::deallocateTable() [0x141fbfb]
	WTF::HashTable<>::~HashTable() [0x141d8f4]
	WTF::HashMap<>::~HashMap() [0x141c9dc]
	WebCore::Supplementable<>::~Supplementable() [0x141ca10]
	WebCore::DOMWindow::~DOMWindow() [0x1416415]
	WTF::RefCounted<>::deref() [0xcf246e]
	WebCore::V8DOMWindow::derefObject() [0x197a116]
	WebCore::WrapperTypeInfo::derefObject() [0x1546266]
	WebCore::DOMData::derefObject() [0x1546235]
	WebCore::DOMData::handleWeakObject<>() [0x1546893]
	WebCore::DOMDataStore::weakDOMObjectCallback() [0x154650f]
	v8::internal::GlobalHandles::Node::PostGarbageCollectionProcessing() [0x928c30]
	v8::internal::GlobalHandles::PostGarbageCollectionProcessing() [0x927706]
	v8::internal::Heap::PerformGarbageCollection() [0x936888]
	v8::internal::Heap::CollectGarbage() [0x935b09]
	v8::internal::Heap::CollectGarbage() [0x912c33]
	v8::internal::Heap::CollectAllGarbage() [0x9357b4]
	v8::internal::GCExtension::GC() [0xb486a7]
	v8::internal::HandleApiCallHelper<>() [0x8d2747]
	v8::internal::Builtin_Impl_HandleApiCall() [0x8cd1de]
	v8::internal::Builtin_HandleApiCall() [0x8cd1af]
	0x2452ee60614e
None

Please take a look.
Comment 14 Adam Barth 2012-03-01 10:39:05 PST
I'm attempting a rollout.  If I don't succeed quickly enough, please feel free to roll the patch out.
Comment 15 Adam Barth 2012-03-01 11:01:27 PST
Reverted r109336 for reason:

It's causing some crashes

Committed r109370: <http://trac.webkit.org/changeset/109370>
Comment 16 Adam Barth 2012-03-01 12:12:37 PST
Turns out I forgot to call disconnectFrame() on the base class in the DOMWindowIndexedDatabase override.
Comment 17 Adam Barth 2012-03-01 12:30:03 PST
Committed r109392: <http://trac.webkit.org/changeset/109392>