Bug 80002 - Fallback elements in Non-youngest shadow tree should not be rendered.
Summary: Fallback elements in Non-youngest shadow tree should not be rendered.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-29 21:01 PST by Shinya Kawanaka
Modified: 2012-02-29 23:58 PST (History)
6 users (show)

See Also:


Attachments
Patch (7.49 KB, patch)
2012-02-29 21:26 PST, Shinya Kawanaka
morrita: review+
Details | Formatted Diff | Diff
Patch (11.47 KB, patch)
2012-02-29 23:46 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch for landing (11.48 KB, patch)
2012-02-29 23:53 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-02-29 21:01:10 PST
Why does it take 'fallback' argument and it creates a fallback text if 'fallback' is not provided?
It's very confusing...
Comment 1 Shinya Kawanaka 2012-02-29 21:26:18 PST
Created attachment 129628 [details]
Patch
Comment 2 Shinya Kawanaka 2012-02-29 21:57:34 PST
Committed r109309: <http://trac.webkit.org/changeset/109309>
Comment 3 Shinya Kawanaka 2012-02-29 23:11:10 PST
Reverted r109309 for reason:

broke

Committed r109315: <http://trac.webkit.org/changeset/109315>
Comment 4 Shinya Kawanaka 2012-02-29 23:33:31 PST
I found a bug in NodeRenderingContext. Fallback elements in non-youngest shadow tree was rendered... It should not be rendered.
Comment 5 Shinya Kawanaka 2012-02-29 23:34:04 PST
Let's reuse this bug to fix it.
Comment 6 Shinya Kawanaka 2012-02-29 23:46:06 PST
Created attachment 129644 [details]
Patch
Comment 7 Hajime Morrita 2012-02-29 23:50:24 PST
Comment on attachment 129644 [details]
Patch

Looks OK. Please nominate the test name in ChangeLog.
Comment 8 Shinya Kawanaka 2012-02-29 23:53:49 PST
Created attachment 129646 [details]
Patch for landing
Comment 9 Shinya Kawanaka 2012-02-29 23:58:47 PST
Committed r109321: <http://trac.webkit.org/changeset/109321>