Bug 79965 - [CMake] Fix build on 64-bit platforms with SHARED_CORE=ON after r109197.
Summary: [CMake] Fix build on 64-bit platforms with SHARED_CORE=ON after r109197.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-29 18:24 PST by Raphael Kubo da Costa (:rakuco)
Modified: 2012-02-29 18:40 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.66 KB, patch)
2012-02-29 18:26 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff
Reference this bug in the ChangeLog (1.72 KB, patch)
2012-02-29 18:35 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2012-02-29 18:24:52 PST
[CMake] Fix build on 64-bit platforms with SHARED_CORE=ON after r109197.
Comment 1 Raphael Kubo da Costa (:rakuco) 2012-02-29 18:26:00 PST
Created attachment 129575 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-02-29 18:29:16 PST
I was going to commit this directly without filing a bug report, but since svn.webkit.org seems to be down again I figured it would be a good idea to create the bug to make it serve as a heads-up to everyone interested in CMake.

CMake automatically passes -fPIC to the compiler when creating shared libraries, but it doesn't do that for static libs. Since WTF is now always built as a static lib, shared libraries such as JSC failed to link against it on platforms such as x86-64.
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-02-29 18:35:16 PST
Created attachment 129609 [details]
Reference this bug in the ChangeLog
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-02-29 18:40:01 PST
Committed r109295: <http://trac.webkit.org/changeset/109295>