RESOLVED FIXED79955
Some trivial file stream cleanup 
https://bugs.webkit.org/show_bug.cgi?id=79955
Summary Some trivial file stream cleanup
Alexey Proskuryakov
Reported 2012-02-29 15:59:16 PST
Not much to see here...
Attachments
proposed patch (7.22 KB, patch)
2012-02-29 16:07 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
without unneeded changes (6.18 KB, patch)
2012-02-29 16:29 PST, Alexey Proskuryakov 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2012-02-29 16:07:35 PST
Created attachment 129543 [details] proposed patch
Jian Li
Comment 2 2012-02-29 16:20:43 PST
Why do we need to include ValueCheck.h in AsyncFileStream.h?
Alexey Proskuryakov
Comment 3 2012-02-29 16:28:02 PST
Ah yes, I ended up not using it. Please ignore the include, and JavaScriptCore changes.
Alexey Proskuryakov
Comment 4 2012-02-29 16:29:46 PST
Created attachment 129550 [details] without unneeded changes
WebKit Review Bot
Comment 5 2012-02-29 16:32:23 PST
Attachment 129550 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/fileapi/FileStreamProxy.h:65: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 6 2012-03-01 10:06:33 PST
Committed <http://trac.webkit.org/changeset/109360>.
Note You need to log in before you can comment on or make changes to this bug.