Bug 79955 - Some trivial file stream cleanup
Summary: Some trivial file stream cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-29 15:59 PST by Alexey Proskuryakov
Modified: 2012-03-01 10:06 PST (History)
3 users (show)

See Also:

Attachments
proposed patch (7.22 KB, patch)
2012-02-29 16:07 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
without unneeded changes (6.18 KB, patch)
2012-02-29 16:29 PST, Alexey Proskuryakov 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2012-02-29 15:59:16 PST 
Not much to see here...
Comment 1 Alexey Proskuryakov 2012-02-29 16:07:35 PST 
Created attachment 129543 [details]
proposed patch
Comment 2 Jian Li 2012-02-29 16:20:43 PST 
Why do we need to include ValueCheck.h in AsyncFileStream.h?
Comment 3 Alexey Proskuryakov 2012-02-29 16:28:02 PST 
Ah yes, I ended up not using it. Please ignore the include, and JavaScriptCore changes.
Comment 4 Alexey Proskuryakov 2012-02-29 16:29:46 PST 
Created attachment 129550 [details]
without unneeded changes
Comment 5 WebKit Review Bot 2012-02-29 16:32:23 PST 
Attachment 129550 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/fileapi/FileStreamProxy.h:65:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Alexey Proskuryakov 2012-03-01 10:06:33 PST 
Committed <http://trac.webkit.org/changeset/109360>.