Bug 79950 - IndexedDB: IDBDatabase.objectStoreNames and IDObjectStore.indexNames results should be sorted
Summary: IndexedDB: IDBDatabase.objectStoreNames and IDObjectStore.indexNames results ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-29 15:01 PST by Joshua Bell
Modified: 2012-02-29 21:23 PST (History)
3 users (show)

See Also:


Attachments
Patch (9.96 KB, patch)
2012-02-29 15:03 PST, Joshua Bell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-02-29 15:01:31 PST
IndexedDB: IDBDatabase.objectStoreNames and IDObjectStore.indexNames results should be sorted
Comment 1 Joshua Bell 2012-02-29 15:03:21 PST
Created attachment 129526 [details]
Patch
Comment 2 Joshua Bell 2012-02-29 15:04:41 PST
Not high priority, but easy.
Comment 3 Joshua Bell 2012-02-29 15:05:21 PST
Note that this is not in the spec yet, but there is consensus in the tracking bug for it:

https://www.w3.org/Bugs/Public/show_bug.cgi?id=16013
Comment 4 David Grogan 2012-02-29 15:11:21 PST
LGTM idb-wise
Comment 5 Tony Chang 2012-02-29 16:34:04 PST
Comment on attachment 129526 [details]
Patch

This is fine, but arv tells me that in the long run, DOMStringList is going away.
Comment 6 Joshua Bell 2012-02-29 16:35:33 PST
(In reply to comment #5)
> (From update of attachment 129526 [details])
> This is fine, but arv tells me that in the long run, DOMStringList is going away.

Yeah, tracking that as: http://code.google.com/p/chromium/issues/detail?id=115665
Comment 7 Tony Chang 2012-02-29 16:37:13 PST
Comment on attachment 129526 [details]
Patch

Also, it's a bit inefficient that we sort each time we access the property rather than using a sorted hash map (hashset), but last I checked, this data structure doesn't exist wtf.
Comment 8 WebKit Review Bot 2012-02-29 18:43:57 PST
Comment on attachment 129526 [details]
Patch

Rejecting attachment 129526 [details] from commit-queue.

jsbell@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 9 Joshua Bell 2012-02-29 19:42:47 PST
Comment on attachment 129526 [details]
Patch

Must have been a glitch, trying again...
Comment 10 WebKit Review Bot 2012-02-29 21:23:14 PST
Comment on attachment 129526 [details]
Patch

Clearing flags on attachment: 129526

Committed r109305: <http://trac.webkit.org/changeset/109305>
Comment 11 WebKit Review Bot 2012-02-29 21:23:19 PST
All reviewed patches have been landed.  Closing bug.