RESOLVED WONTFIX Bug 7995
is css/maketokenizer is removing the type defs 
https://bugs.webkit.org/show_bug.cgi?id=7995
Summary is css/maketokenizer is removing the type defs
Michael Emmel
Reported 2006-03-26 11:00:33 PST
It seems on OSX the flex typedefs are being picked up from the system while this is not true under linux. Patch attached
Attachments
Patch to add typedefs (844 bytes, patch)
2006-03-26 11:03 PST, Michael Emmel 		darin: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Emmel
Comment 1 2006-03-26 11:03:19 PST
Created attachment 7313 [details] Patch to add typedefs
Darin Adler
Comment 2 2006-03-27 17:09:36 PST
Comment on attachment 7313 [details] Patch to add typedefs I'm not sure I understand what's going on here. The tokenizer.cpp file generated by our version of flex, 2.5.4, doesn't contain any references to types with a "flex_" prefix. It's not true that under OS X the flex types are being "picked up from the OS". What's happening is that these types don't exist at all in the version of flex we're using. I think there are probably better ways to fix this. The maketokenizer script throws away a lot of what flex generates -- we should probably fix it to keep around the typedefs.
Darin Adler
Comment 3 2006-03-27 17:10:36 PST
Comment on attachment 7313 [details] Patch to add typedefs This is not the right fix -- we don't want our own copy of the flex typedefs. But I'm sure we can tweak the script another way to make it work with this newer version of flex. It's worth looking at the latest KDE version of this script to see what they decided to do, since this is the unmodified original script we got from them.
Eric Seidel (no email)
Comment 4 2007-09-30 11:30:27 PDT
This must have been worked around in some other way in the last 9 months, no? I would think this bug could be closed by now. Last I knew GTKWebKit even has its own buildbot: http://build.webkit.org/post-commit-linux-gtk
Note You need to log in before you can comment on or make changes to this bug.