Bug 79943 - Sync PageCache debugging with PageCache behaviour
Summary: Sync PageCache debugging with PageCache behaviour
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Peters
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-29 14:10 PST by Gavin Peters
Modified: 2012-03-02 12:11 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.76 KB, patch)
2012-02-29 14:23 PST, Gavin Peters 		no flags Details | Formatted Diff | Diff
Patch (4.75 KB, patch)
2012-03-02 10:01 PST, Gavin Peters 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Peters 2012-02-29 14:10:25 PST 
Sync PageCache debugging with PageCache behaviour
Comment 1 Gavin Peters 2012-02-29 14:23:33 PST 
Created attachment 129517 [details]
Patch
Comment 2 Gavin Peters 2012-02-29 14:24:43 PST 
This is the clean-up-the-debugging part of now-retired Bug 79269.
Comment 3 WebKit Review Bot 2012-03-02 06:46:30 PST 
Comment on attachment 129517 [details]
Patch

Rejecting attachment 129517 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
as type 'int'
Source/WebCore/history/PageCache.cpp:209: error: cannot pass objects of non-POD type 'class WTF::String' through '...'; call will abort at runtime
Source/WebCore/history/PageCache.cpp:209: error: format '%s' expects type 'char*', but argument 5 has type 'int'
  CXX(target) out/Debug/obj.target/webcore_remaining/Source/WebCore/inspector/DOMEditor.o
make: *** [out/Debug/obj.target/webcore_remaining/Source/WebCore/history/PageCache.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/11751954
Comment 4 Gavin Peters 2012-03-02 10:01:47 PST 
Created attachment 129915 [details]
Patch
Comment 5 Gavin Peters 2012-03-02 10:02:48 PST 
It seems I neglected to test my patch on Chromium.  Now done, I'll wait on EWS and then cq+.
Comment 6 Adam Barth 2012-03-02 11:27:35 PST 
Comment on attachment 129915 [details]
Patch

Forwarding beidson's r+.
Comment 7 WebKit Review Bot 2012-03-02 12:11:35 PST 
Comment on attachment 129915 [details]
Patch

Clearing flags on attachment: 129915

Committed r109598: <http://trac.webkit.org/changeset/109598>
Comment 8 WebKit Review Bot 2012-03-02 12:11:41 PST 
All reviewed patches have been landed.  Closing bug.