WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
79943
Sync PageCache debugging with PageCache behaviour
https://bugs.webkit.org/show_bug.cgi?id=79943
Summary
Sync PageCache debugging with PageCache behaviour
Gavin Peters
Reported
2012-02-29 14:10:25 PST
Sync PageCache debugging with PageCache behaviour
Attachments
Patch
(4.76 KB, patch)
2012-02-29 14:23 PST
,
Gavin Peters
no flags
Details
Formatted Diff
Diff
Patch
(4.75 KB, patch)
2012-03-02 10:01 PST
,
Gavin Peters
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Gavin Peters
Comment 1
2012-02-29 14:23:33 PST
Created
attachment 129517
[details]
Patch
Gavin Peters
Comment 2
2012-02-29 14:24:43 PST
This is the clean-up-the-debugging part of now-retired
Bug 79269
.
WebKit Review Bot
Comment 3
2012-03-02 06:46:30 PST
Comment on
attachment 129517
[details]
Patch Rejecting
attachment 129517
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: as type 'int' Source/WebCore/history/PageCache.cpp:209: error: cannot pass objects of non-POD type 'class WTF::String' through '...'; call will abort at runtime Source/WebCore/history/PageCache.cpp:209: error: format '%s' expects type 'char*', but argument 5 has type 'int' CXX(target) out/Debug/obj.target/webcore_remaining/Source/WebCore/inspector/DOMEditor.o make: *** [out/Debug/obj.target/webcore_remaining/Source/WebCore/history/PageCache.o] Error 1 make: *** Waiting for unfinished jobs.... Full output:
http://queues.webkit.org/results/11751954
Gavin Peters
Comment 4
2012-03-02 10:01:47 PST
Created
attachment 129915
[details]
Patch
Gavin Peters
Comment 5
2012-03-02 10:02:48 PST
It seems I neglected to test my patch on Chromium. Now done, I'll wait on EWS and then cq+.
Adam Barth
Comment 6
2012-03-02 11:27:35 PST
Comment on
attachment 129915
[details]
Patch Forwarding beidson's r+.
WebKit Review Bot
Comment 7
2012-03-02 12:11:35 PST
Comment on
attachment 129915
[details]
Patch Clearing flags on attachment: 129915 Committed
r109598
: <
http://trac.webkit.org/changeset/109598
>
WebKit Review Bot
Comment 8
2012-03-02 12:11:41 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug