Bug 79933 - [chromium] Use webkit_support to create session storage namespaces in DRT.
Summary: [chromium] Use webkit_support to create session storage namespaces in DRT.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Nordman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-29 12:44 PST by Michael Nordman
Modified: 2012-03-01 16:25 PST (History)
4 users (show)

See Also:

Attachments
drt (1.28 KB, patch)
2012-02-29 13:38 PST, Michael Nordman 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Nordman 2012-02-29 12:44:58 PST 
Use webkit_support::createSessionStorageNamespace() to create session storage namespaces in DRT instead directly using the factory method in the WebKit api.

See related issue http://code.google.com/p/chromium/issues/detail?id=106763
Comment 1 Michael Nordman 2012-02-29 13:38:42 PST 
Created attachment 129508 [details]
drt

commit needs to wait for the chromium-side change in which the new webkit_support function is defined to land, http://codereview.chromium.org/9429029/
Comment 2 Michael Nordman 2012-02-29 14:12:17 PST 
tony, ptal
Comment 3 Tony Chang 2012-02-29 14:20:32 PST 
Comment on attachment 129508 [details]
drt

View in context: https://bugs.webkit.org/attachment.cgi?id=129508&action=review

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:276
> -    return WebKit::WebStorageNamespace::createSessionStorageNamespace(quota);
> +    return webkit_support::CreateSessionStorageNamespace(quota);

I don't see this method in webkit/support/webkit_support.h.  Am I missing something?
Comment 4 Tony Chang 2012-02-29 14:21:35 PST 
Comment on attachment 129508 [details]
drt

Sorry, just read comment #1.  You'll have to roll DEPS in Source/WebKit/chromium/DEPS after the chromium change lands.
Comment 5 Michael Nordman 2012-02-29 14:25:57 PST 
(In reply to comment #4)
> You'll have to roll DEPS in Source/WebKit/chromium/DEPS after the chromium change lands.

will do, thnx
Comment 6 WebKit Review Bot 2012-02-29 19:05:08 PST 
Comment on attachment 129508 [details]
drt

Attachment 129508 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11766134
Comment 7 Michael Nordman 2012-03-01 15:29:17 PST 
Comment on attachment 129508 [details]
drt

putting in the commit-queue now that we've rolled DEPs to 124511 (well past 124337)
Comment 8 WebKit Review Bot 2012-03-01 16:25:29 PST 
Comment on attachment 129508 [details]
drt

Clearing flags on attachment: 129508

Committed r109462: <http://trac.webkit.org/changeset/109462>
Comment 9 WebKit Review Bot 2012-03-01 16:25:36 PST 
All reviewed patches have been landed.  Closing bug.