Bug 79929 – Autocomplete attribute should apply to textarea's.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Mike Fenton]

The blackberry styling for autocomplete should be applicable to textarea's as well as regular input fields.

[Mike Fenton]

Created attachment 129482 [details]
Patch

[Antonio Gomes]

Comment on attachment 129482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129482&action=review

> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:183
> +    return elementAttributeState(element, QualifiedName(nullAtom, "autocorrect", nullAtom));

I would do

DEFINE_STATIC_LOCAL(AtomicString, autocorrect, ("autocorrect"));

> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:191
> +AttributeState elementAttributeState(const Element* element, const QualifiedName& attributeName)

'AttributeState' reads too generic for its scoped purposes, I would think.

[Mike Fenton]

Created attachment 129489 [details]
Patch based on suggestion.

[Mike Fenton]

Created attachment 129501 [details]
Updated patch based on suggestion.

[WebKit Review Bot]

Comment on attachment 129482 [details]
Patch

Clearing flags on attachment: 129482

Committed r109284: <http://trac.webkit.org/changeset/109284>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Mike Fenton]

Created attachment 129684 [details]
Updated second patch.

[Mike Fenton]

Reopening to land followup patch.

[WebKit Review Bot]

Comment on attachment 129501 [details]
Updated patch based on suggestion.

Rejecting attachment 129501 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/11779449

[WebKit Review Bot]

Comment on attachment 129684 [details]
Updated second patch.

Rejecting attachment 129684 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/blackberry/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/11779451

[Mike Fenton]

Created attachment 129688 [details]
Updated patch with reviewer in Changelog.

[WebKit Review Bot]

The commit-queue encountered the following flaky tests while processing attachment 129688 [details]:

fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Review Bot]

Comment on attachment 129688 [details]
Updated patch with reviewer in Changelog.

Rejecting attachment 129688 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 Source/WebKit/chromium/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Web Inspector: [InspectorIndexedDB] Show tooltips with IndexedDB objects meta information

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/11769544

[WebKit Review Bot]

Comment on attachment 129688 [details]
Updated patch with reviewer in Changelog.

Clearing flags on attachment: 129688

Committed r109430: <http://trac.webkit.org/changeset/109430>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.