Bug 79929 - Autocomplete attribute should apply to textarea's.
Summary: Autocomplete attribute should apply to textarea's.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Fenton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-29 11:34 PST by Mike Fenton
Modified: 2012-03-01 14:42 PST (History)
2 users (show)

See Also:


Attachments
Patch (8.14 KB, patch)
2012-02-29 11:38 PST, Mike Fenton
no flags Details | Formatted Diff | Diff
Patch based on suggestion. (2.43 KB, patch)
2012-02-29 12:42 PST, Mike Fenton
no flags Details | Formatted Diff | Diff
Updated patch based on suggestion. (2.16 KB, patch)
2012-02-29 13:16 PST, Mike Fenton
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Updated second patch. (2.04 KB, patch)
2012-03-01 05:27 PST, Mike Fenton
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Updated patch with reviewer in Changelog. (2.04 KB, patch)
2012-03-01 05:50 PST, Mike Fenton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Fenton 2012-02-29 11:34:37 PST
The blackberry styling for autocomplete should be applicable to textarea's as well as regular input fields.
Comment 1 Mike Fenton 2012-02-29 11:38:24 PST
Created attachment 129482 [details]
Patch
Comment 2 Antonio Gomes 2012-02-29 12:08:13 PST
Comment on attachment 129482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129482&action=review

> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:183
> +    return elementAttributeState(element, QualifiedName(nullAtom, "autocorrect", nullAtom));

I would do

DEFINE_STATIC_LOCAL(AtomicString, autocorrect, ("autocorrect"));

> Source/WebKit/blackberry/WebKitSupport/DOMSupport.cpp:191
> +AttributeState elementAttributeState(const Element* element, const QualifiedName& attributeName)

'AttributeState' reads too generic for its scoped purposes, I would think.
Comment 3 Mike Fenton 2012-02-29 12:42:15 PST
Created attachment 129489 [details]
Patch based on suggestion.
Comment 4 Mike Fenton 2012-02-29 13:16:35 PST
Created attachment 129501 [details]
Updated patch based on suggestion.
Comment 5 WebKit Review Bot 2012-02-29 16:34:17 PST
Comment on attachment 129482 [details]
Patch

Clearing flags on attachment: 129482

Committed r109284: <http://trac.webkit.org/changeset/109284>
Comment 6 WebKit Review Bot 2012-02-29 16:34:21 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Mike Fenton 2012-03-01 05:27:57 PST
Created attachment 129684 [details]
Updated second patch.
Comment 8 Mike Fenton 2012-03-01 05:28:19 PST
Reopening to land followup patch.
Comment 9 WebKit Review Bot 2012-03-01 05:48:26 PST
Comment on attachment 129501 [details]
Updated patch based on suggestion.

Rejecting attachment 129501 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/11779449
Comment 10 WebKit Review Bot 2012-03-01 05:49:55 PST
Comment on attachment 129684 [details]
Updated second patch.

Rejecting attachment 129684 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/blackberry/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/11779451
Comment 11 Mike Fenton 2012-03-01 05:50:13 PST
Created attachment 129688 [details]
Updated patch with reviewer in Changelog.
Comment 12 WebKit Review Bot 2012-03-01 09:49:40 PST
The commit-queue encountered the following flaky tests while processing attachment 129688 [details]:

fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org)
The commit-queue is continuing to process your patch.
Comment 13 WebKit Review Bot 2012-03-01 09:51:11 PST
Comment on attachment 129688 [details]
Updated patch with reviewer in Changelog.

Rejecting attachment 129688 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 Source/WebKit/chromium/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Web Inspector: [InspectorIndexedDB] Show tooltips with IndexedDB objects meta information

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/11769544
Comment 14 WebKit Review Bot 2012-03-01 14:42:13 PST
Comment on attachment 129688 [details]
Updated patch with reviewer in Changelog.

Clearing flags on attachment: 129688

Committed r109430: <http://trac.webkit.org/changeset/109430>
Comment 15 WebKit Review Bot 2012-03-01 14:42:17 PST
All reviewed patches have been landed.  Closing bug.