Bug 79921 - Web Inspector: timeline markers are not shown on the timeline panel
Summary: Web Inspector: timeline markers are not shown on the timeline panel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-29 09:19 PST by Andrey Kosyakov
Modified: 2012-02-29 09:36 PST (History)
10 users (show)

See Also:


Attachments
Patch (2.00 KB, patch)
2012-02-29 09:20 PST, Andrey Kosyakov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-02-29 09:19:51 PST
1. navigate to webkit.org
2. open inspector
3. switch to Timeline panel
4. start recording timeline
5. run console.markTimeline() in console

EXPECTED: yellow mark on the timeline grid and in the overview
ACTUAL: no marks anywhere
Comment 1 Andrey Kosyakov 2012-02-29 09:20:53 PST
Created attachment 129462 [details]
Patch
Comment 2 Pavel Feldman 2012-02-29 09:24:32 PST
Comment on attachment 129462 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129462&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:467
> +        WebInspector.TimelinePanel.forAllRecords([ formattedRecord ], addTimestampRecords.bind(this));

I wound not bind a function per record.
Comment 3 Andrey Kosyakov 2012-02-29 09:36:43 PST
Committed r109221: <http://trac.webkit.org/changeset/109221>