Bug 79911 - Web Inspector: move heap snapshot nodes data to external array.
Summary: Web Inspector: move heap snapshot nodes data to external array.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on: 80212
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-29 07:29 PST by Ilya Tikhonovsky
Modified: 2012-03-12 07:00 PDT (History)
17 users (show)

See Also:


Attachments
Patch (3.24 KB, patch)
2012-02-29 07:31 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (5.32 KB, patch)
2012-02-29 08:53 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
polished patch (4.87 KB, patch)
2012-02-29 22:23 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (5.93 KB, patch)
2012-03-01 02:03 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (7.93 KB, patch)
2012-03-01 05:59 PST, Ilya Tikhonovsky
vsevik: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-02-29 07:29:24 PST
%subj%
Comment 1 Ilya Tikhonovsky 2012-02-29 07:31:49 PST
Created attachment 129449 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-02-29 08:53:20 PST
Created attachment 129459 [details]
Patch
Comment 3 Ilya Tikhonovsky 2012-02-29 22:23:29 PST
Created attachment 129635 [details]
polished patch
Comment 4 Ilya Tikhonovsky 2012-03-01 02:03:33 PST
Created attachment 129668 [details]
Patch
Comment 5 Vsevolod Vlasov 2012-03-01 05:00:28 PST
Comment on attachment 129668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129668&action=review

> Source/WebCore/inspector/front-end/HeapSnapshot.js:739
> +    else { // This is a fallback for heap-snapshot-loader.html Layout test.

Could you please move the code in else to the test.
Comment 6 Ilya Tikhonovsky 2012-03-01 05:59:50 PST
Created attachment 129692 [details]
Patch
Comment 7 Ilya Tikhonovsky 2012-03-01 06:15:45 PST
Committed r109343: <http://trac.webkit.org/changeset/109343>
Comment 8 Ilya Tikhonovsky 2012-03-12 07:00:07 PDT
Committed r110423: <http://trac.webkit.org/changeset/110423>