WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
79911
Web Inspector: move heap snapshot nodes data to external array.
https://bugs.webkit.org/show_bug.cgi?id=79911
Summary
Web Inspector: move heap snapshot nodes data to external array.
Ilya Tikhonovsky
Reported
2012-02-29 07:29:24 PST
%subj%
Attachments
Patch
(3.24 KB, patch)
2012-02-29 07:31 PST
,
Ilya Tikhonovsky
no flags
Details
Formatted Diff
Diff
Patch
(5.32 KB, patch)
2012-02-29 08:53 PST
,
Ilya Tikhonovsky
no flags
Details
Formatted Diff
Diff
polished patch
(4.87 KB, patch)
2012-02-29 22:23 PST
,
Ilya Tikhonovsky
no flags
Details
Formatted Diff
Diff
Patch
(5.93 KB, patch)
2012-03-01 02:03 PST
,
Ilya Tikhonovsky
no flags
Details
Formatted Diff
Diff
Patch
(7.93 KB, patch)
2012-03-01 05:59 PST
,
Ilya Tikhonovsky
vsevik
: review+
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1
2012-02-29 07:31:49 PST
Created
attachment 129449
[details]
Patch
Ilya Tikhonovsky
Comment 2
2012-02-29 08:53:20 PST
Created
attachment 129459
[details]
Patch
Ilya Tikhonovsky
Comment 3
2012-02-29 22:23:29 PST
Created
attachment 129635
[details]
polished patch
Ilya Tikhonovsky
Comment 4
2012-03-01 02:03:33 PST
Created
attachment 129668
[details]
Patch
Vsevolod Vlasov
Comment 5
2012-03-01 05:00:28 PST
Comment on
attachment 129668
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=129668&action=review
> Source/WebCore/inspector/front-end/HeapSnapshot.js:739 > + else { // This is a fallback for heap-snapshot-loader.html Layout test.
Could you please move the code in else to the test.
Ilya Tikhonovsky
Comment 6
2012-03-01 05:59:50 PST
Created
attachment 129692
[details]
Patch
Ilya Tikhonovsky
Comment 7
2012-03-01 06:15:45 PST
Committed
r109343
: <
http://trac.webkit.org/changeset/109343
>
Ilya Tikhonovsky
Comment 8
2012-03-12 07:00:07 PDT
Committed
r110423
: <
http://trac.webkit.org/changeset/110423
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug