Bug 79906 - Web Inspector: abstract out the common pattern of creating auto-updated locations.
Summary: Web Inspector: abstract out the common pattern of creating auto-updated locat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-29 07:10 PST by Pavel Podivilov
Modified: 2012-03-01 02:29 PST (History)
10 users (show)

See Also:

Attachments
Patch (14.20 KB, patch)
2012-02-29 07:12 PST, Pavel Podivilov 		vsevik: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2012-02-29 07:10:40 PST 
Web Inspector: abstract out the common pattern of creating auto-updated locations.
Comment 1 Pavel Podivilov 2012-02-29 07:12:52 PST 
Created attachment 129441 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-02-29 09:05:23 PST 
Comment on attachment 129441 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129441&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:891
> +    formatRawSourceCodeAnchor: function(anchor, uiLocation)

Could you please rename this method to something like formatLiveAnchor now that it does not depend on rawSourceCode?
Comment 3 Pavel Podivilov 2012-03-01 02:29:24 PST 
Committed r109328: <http://trac.webkit.org/changeset/109328>