Web Notification crashes the browser at permission dialog and after click on the notification. Internal PR: 140936
Created attachment 129426 [details] Patch which is internally reviewed by Robin Qiu. Internally reviewed and approved by Roin Qiu.
Comment on attachment 129426 [details] Patch which is internally reviewed by Robin Qiu. View in context: https://bugs.webkit.org/attachment.cgi?id=129426&action=review > Source/WebKit/blackberry/ChangeLog:11 > + [BlackBerry] Web Notification crashes the browser. > + https://bugs.webkit.org/show_bug.cgi?id=79897 > + > + Reviewed by NOBODY (OOPS!). > + > + * WebCoreSupport/NotificationPresenterImpl.cpp: > + (WebKit::NotificationPresenterImpl::onPermission): > + (WebKit::NotificationPresenterImpl::notificationClicked): > + mind to explain what your patch does, how it fixes the crash, what was the cause, how to test, etc?
Created attachment 129615 [details] patch-v2 with more info about the patch
Comment on attachment 129615 [details] patch-v2 with more info about the patch Attachment 129615 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11769184 New failing tests: fast/workers/storage/use-same-database-in-page-and-workers.html
(In reply to comment #4) > (From update of attachment 129615 [details]) > Attachment 129615 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/11769184 > > New failing tests: > fast/workers/storage/use-same-database-in-page-and-workers.html Seems not related to this patch. Letting cq try again.
Comment on attachment 129615 [details] patch-v2 with more info about the patch Rejecting attachment 129615 [details] from commit-queue. New failing tests: fast/workers/storage/use-same-database-in-page-and-workers.html Full output: http://queues.webkit.org/results/11751349
Comment on attachment 129615 [details] patch-v2 with more info about the patch Rejecting attachment 129615 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11766448
Comment on attachment 129615 [details] patch-v2 with more info about the patch Rejecting attachment 129615 [details] from commit-queue. New failing tests: fast/workers/storage/use-same-database-in-page-and-workers.html Full output: http://queues.webkit.org/results/11751427
Comment on attachment 129615 [details] patch-v2 with more info about the patch Rejecting attachment 129615 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: FLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Remove last ENABLED(INDEXED_DATABASE) ifdef from WebCore proper When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/11776690
Comment on attachment 129615 [details] patch-v2 with more info about the patch Clearing flags on attachment: 129615 Committed r109475: <http://trac.webkit.org/changeset/109475>
All reviewed patches have been landed. Closing bug.