Bug 79868 - Overlay scrollbars should respond to AppKit's NSEventPhaseMayBegin
Summary: Overlay scrollbars should respond to AppKit's NSEventPhaseMayBegin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified OS X 10.7
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-02-28 21:51 PST by Beth Dakin
Modified: 2012-02-29 11:52 PST (History)
1 user (show)

See Also:

Attachments
Patch (8.48 KB, patch)
2012-02-28 21:56 PST, Beth Dakin 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2012-02-28 21:51:58 PST 
Overlay scrollbars should respond to AppKit's NSEventPhaseMayBegin. <rdar://problem/10688637>
Comment 1 Beth Dakin 2012-02-28 21:56:41 PST 
Created attachment 129385 [details]
Patch
Comment 2 Anders Carlsson 2012-02-29 08:59:37 PST 
Comment on attachment 129385 [details]
Patch

I think you should change all handleWheelEventPhase functions to just take the phase enum, that way you'll avoid copying the event object when all you want is the phase.

Looks great otherwise!
Comment 3 Anders Carlsson 2012-02-29 09:02:47 PST 
Comment on attachment 129385 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129385&action=review

> Source/WebCore/platform/mac/ScrollAnimatorMac.h:89
> +    virtual void handleWheelEventPhase(const PlatformWheelEvent&);

This could be marked OVERRIDE.
Comment 4 Beth Dakin 2012-02-29 11:52:44 PST 
Thanks Anders! Committed change with http://trac.webkit.org/changeset/109237