RESOLVED FIXED Bug 79868
Overlay scrollbars should respond to AppKit's NSEventPhaseMayBegin 
https://bugs.webkit.org/show_bug.cgi?id=79868
Summary Overlay scrollbars should respond to AppKit's NSEventPhaseMayBegin
Beth Dakin
Reported 2012-02-28 21:51:58 PST
Overlay scrollbars should respond to AppKit's NSEventPhaseMayBegin. <rdar://problem/10688637>
Attachments
Patch (8.48 KB, patch)
2012-02-28 21:56 PST, Beth Dakin 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2012-02-28 21:56:41 PST
Created attachment 129385 [details] Patch
Anders Carlsson
Comment 2 2012-02-29 08:59:37 PST
Comment on attachment 129385 [details] Patch I think you should change all handleWheelEventPhase functions to just take the phase enum, that way you'll avoid copying the event object when all you want is the phase. Looks great otherwise!
Anders Carlsson
Comment 3 2012-02-29 09:02:47 PST
Comment on attachment 129385 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129385&action=review > Source/WebCore/platform/mac/ScrollAnimatorMac.h:89 > + virtual void handleWheelEventPhase(const PlatformWheelEvent&); This could be marked OVERRIDE.
Beth Dakin
Comment 4 2012-02-29 11:52:44 PST
Thanks Anders! Committed change with http://trac.webkit.org/changeset/109237
Note You need to log in before you can comment on or make changes to this bug.