Bug 79866 - [BlackBerry]Make about:cache feature available in release version.
Summary: [BlackBerry]Make about:cache feature available in release version.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-28 21:42 PST by Jason Liu
Modified: 2012-02-29 20:20 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.90 KB, patch)
2012-02-28 21:59 PST, Jason Liu 		no flags Details | Formatted Diff | Diff
Patch (1.89 KB, patch)
2012-02-28 23:10 PST, Jason Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Liu 2012-02-28 21:42:35 PST 
Make about:cache feature available in release version.
Comment 1 Jason Liu 2012-02-28 21:59:02 PST 
Created attachment 129386 [details]
Patch
Comment 2 Jason Liu 2012-02-28 23:10:50 PST 
Created attachment 129396 [details]
Patch
Comment 3 Jeff Rogers 2012-02-29 15:59:47 PST 
I don't see any changes in both patches, the diffs are identical. Shouldn't we just be removing the entire ifdef line altogether?
Comment 4 Jason Liu 2012-02-29 18:23:44 PST 
(In reply to comment #3)
> I don't see any changes in both patches, the diffs are identical. Shouldn't we just be removing the entire ifdef line altogether?

We need to move "#if !defined(PUBLIC_BUILD) || !PUBLIC_BUILD" down several lines to make about:cache work for release version.

I made the second patch to replace the tab with space in the first one.
Comment 5 Jeff Rogers 2012-02-29 18:35:32 PST 
(In reply to comment #4)
> (In reply to comment #3)
> > I don't see any changes in both patches, the diffs are identical. Shouldn't we just be removing the entire ifdef line altogether?
> 
> We need to move "#if !defined(PUBLIC_BUILD) || !PUBLIC_BUILD" down several lines to make about:cache work for release version.
> 
> I made the second patch to replace the tab with space in the first one.

My mistake, I realized after that you moved it. LGTM.
Comment 6 Antonio Gomes 2012-02-29 19:50:45 PST 
Comment on attachment 129396 [details]
Patch

ja
Comment 7 WebKit Review Bot 2012-02-29 20:20:40 PST 
Comment on attachment 129396 [details]
Patch

Clearing flags on attachment: 129396

Committed r109301: <http://trac.webkit.org/changeset/109301>
Comment 8 WebKit Review Bot 2012-02-29 20:20:48 PST 
All reviewed patches have been landed.  Closing bug.