WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
79860
[EFL] Build warning : comparison between signed and unsigned integer expressions
https://bugs.webkit.org/show_bug.cgi?id=79860
Summary
[EFL] Build warning : comparison between signed and unsigned integer expressions
Byungwoo Lee
Reported
2012-02-28 19:44:34 PST
Hi~ I met build warnings about 'comparison between signed and unsigned integer expressions' on building webkit efl port. ** On release build ($ ./Tools/Scripts/build-webkit --efl) [ 49%] Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/platform/ContextMenu.cpp.o /WebKit/Source/WebCore/platform/ContextMenu.cpp: In function const WebCore::ContextMenuItem* WebCore::findItemWithAction(unsigned int, const WTF::Vector<WebCore::ContextMenuItem, 0u>&): /WebKit/Source/WebCore/platform/ContextMenu.cpp:41: warning: comparison between signed and unsigned integer expressions ... [100%] Building CXX object Source/WebKit/CMakeFiles/ewebkit.dir/efl/ewk/ewk_window_features.cpp.o /WebKit/Source/WebKit/efl/ewk/ewk_view_single.cpp: In function void _ewk_view_screen_move(uint32_t*, size_t, size_t, size_t, size_t, size_t, size_t, size_t): /WebKit/Source/WebKit/efl/ewk/ewk_view_single.cpp:109: warning: comparison between signed and unsigned integer expressions /WebKit/Source/WebKit/efl/ewk/ewk_view_single.cpp:116: warning: comparison between signed and unsigned integer expressions ** On build for DRT test ($ ./Tools/Scripts/build-webkit --efl --touch-events --touch-icon-loading \ --blob --device-orientation --fullscreen-api \ --geolocation --notifications --orientation-events \ --video --workers --shared-workers --request-animation-frame \ --page-visibility-api --cmakearg="-DSHARED_CORE=ON") ... [ 74%] Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/bindings/js/JSEventCustom.cpp.o /WebKit/Source/WebCore/bindings/js/JSDocumentCustom.cpp: In member function JSC::JSValue WebCore::JSDocument::createTouchList(JSC::ExecState*): /WebKit/Source/WebCore/bindings/js/JSDocumentCustom.cpp:122: warning: comparison between signed and unsigned integer expressions
Attachments
Patch
(3.24 KB, patch)
2012-02-28 23:39 PST
,
Byungwoo Lee
no flags
Details
Formatted Diff
Diff
Patch
(3.28 KB, patch)
2012-03-01 18:12 PST
,
Byungwoo Lee
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Byungwoo Lee
Comment 1
2012-02-28 23:39:03 PST
Created
attachment 129400
[details]
Patch
Ryuan Choi
Comment 2
2012-02-28 23:42:19 PST
Comment on
attachment 129400
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=129400&action=review
> Source/WebKit/efl/ewk/ewk_view_single.cpp:109 > + for (uint32_t i = 0; i < copyHeight; i++) {
size_t looks better for me.
Byungwoo Lee
Comment 3
2012-02-29 01:27:44 PST
(In reply to
comment #2
)
> (From update of
attachment 129400
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=129400&action=review
> > Source/WebKit/efl/ewk/ewk_view_single.cpp:109 > > + for (uint32_t i = 0; i < copyHeight; i++) { > size_t looks better for me.
Ok~ I'll fix this and also about the below. + for (uint32_t i = 0; i < exec->argumentCount(); i++) (The return type of ExecState::argumentCount() is size_t) Thanks for the comment.
Byungwoo Lee
Comment 4
2012-03-01 18:12:51 PST
Created
attachment 129788
[details]
Patch
Gyuyoung Kim
Comment 5
2012-03-01 19:26:34 PST
Comment on
attachment 129788
[details]
Patch LGTM too.
WebKit Review Bot
Comment 6
2012-03-02 02:55:51 PST
Comment on
attachment 129788
[details]
Patch Clearing flags on attachment: 129788 Committed
r109544
: <
http://trac.webkit.org/changeset/109544
>
WebKit Review Bot
Comment 7
2012-03-02 02:55:55 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug