RESOLVED WONTFIX 79826
[BlackBerry] Update the WebKit API to use std::string rather than char* 
https://bugs.webkit.org/show_bug.cgi?id=79826
Summary [BlackBerry] Update the WebKit API to use std::string rather than char*
Konrad Piascik
Reported 2012-02-28 13:15:34 PST
Currently there are several methods in both WebPage.h and WebPageClient.h which use char* where std::string would be better suited. These should be updated if possible. This will be a meta bug to track individual changes. This is to encourage smaller patches that are both reviewable and less prone to regressions and breakage.
Attachments
Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2012-03-03 17:51:48 PST
@all, do you have a agreement?
Antonio Gomes
Comment 2 2012-03-03 17:52:30 PST
(In reply to comment #1) > @all, do you have a agreement? err! @all: do we have an agreement?
Joe Mason
Comment 3 2012-03-05 14:17:11 PST
No - I agree that char* should be deprecated, but I think the API should use WebString in most places. (And in NetworkJob::notifyDataReceived and similar, it should use a buffer class that's a thin wrapper around char*, since the data is not actually a string.) std::string will need to be converted to WTF::String eventually anyway, so we might as well do it on the platform side. This will let us avoid char*->std::string->WTF::String conversions.
George Staikos
Comment 4 2012-11-14 11:00:08 PST
No we won't
Note You need to log in before you can comment on or make changes to this bug.