Bug 79816 - More Pasteboard code cleanup
Summary: More Pasteboard code cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-28 11:35 PST by Enrica Casucci
Modified: 2012-02-28 13:58 PST (History)
5 users (show)

See Also:

Attachments
Patch (16.51 KB, patch)
2012-02-28 11:43 PST, Enrica Casucci 		ap: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2012-02-28 11:35:07 PST 
Cleanup the last references to NSPasteboard in the DragClient.h interface.
Comment 1 Enrica Casucci 2012-02-28 11:43:39 PST 
Created attachment 129301 [details]
Patch
Comment 2 Alexey Proskuryakov 2012-02-28 12:06:06 PST 
Comment on attachment 129301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129301&action=review

> Source/WebCore/editing/mac/EditorMac.mm:286
> +    types.append(String(NSStringPboardType));

Is the explicit construction necessary here?

> Source/WebCore/platform/mac/PasteboardHelper.h:-43
> -    class PasteboardHelper {

I love to see "helper" pseudo-classes gone!
Comment 3 WebKit Review Bot 2012-02-28 12:22:46 PST 
Comment on attachment 129301 [details]
Patch

Attachment 129301 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11714031

New failing tests:
css3/filters/effect-invert-hw.html
Comment 4 Enrica Casucci 2012-02-28 13:53:50 PST 
(In reply to comment #2)
> (From update of attachment 129301 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=129301&action=review
> 
> > Source/WebCore/editing/mac/EditorMac.mm:286
> > +    types.append(String(NSStringPboardType));
> 
> Is the explicit construction necessary here?
> 
Yes.
Comment 5 Enrica Casucci 2012-02-28 13:58:47 PST 
http://trac.webkit.org/changeset/109147