We should add size field to Metadata in FileSystem API as proposed in: http://lists.w3.org/Archives/Public/public-webapps/2012JanMar/0905.html
Created attachment 129352 [details] Patch
Comment on attachment 129352 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129352&action=review > Source/WebCore/fileapi/FileSystemCallbacks.cpp:34 > +#include <stdio.h> Why include stdio? > Source/WebCore/fileapi/Metadata.h:41 > class Metadata : public RefCounted<Metadata> { What is the differenence between Metadata and FileMetadata? Metadata::m_metadata is confusing to me. I guess Metadata is what is exposed to js code and FileMetadata is internal. I wonder if m_metadata should be call m_internalMetadata. Slightly more verbose but at least you wouldn't have Metadata::m_metadata.
Comment on attachment 129352 [details] Patch Attachment 129352 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11686064 New failing tests: fast/filesystem/op-get-metadata.html
Created attachment 129367 [details] Patch
Attachment 129367 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] WebKitLibraries/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] WebKitLibraries/WebKitSystemInterface.h:339: The parameter name "layer" adds no information, so it should be removed. [readability/parameter_name] [5] WebKitLibraries/WebKitSystemInterface.h:339: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 5 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.