Bug 79812 - Full screen video volume slider has "progress bar"
Summary: Full screen video volume slider has "progress bar"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified OS X 10.7
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2012-02-28 11:11 PST by Jer Noble
Modified: 2012-02-29 10:55 PST (History)
5 users (show)

See Also:


Attachments
Patch (400.58 KB, patch)
2012-02-28 11:40 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (610.87 KB, patch)
2012-02-28 13:29 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (610.89 KB, patch)
2012-02-28 13:33 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (970.74 KB, patch)
2012-02-28 13:47 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (970.71 KB, patch)
2012-02-28 16:12 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (229.19 KB, patch)
2012-02-28 16:52 PST, Jer Noble
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2012-02-28 11:11:46 PST
Enlarging an embedded video to full screen shows that the volume slider appears to have a "progress bar" (see attached image).
Comment 1 Jer Noble 2012-02-28 11:12:06 PST
<rdar://problem/9432696>
Comment 2 Jer Noble 2012-02-28 11:40:10 PST
Created attachment 129300 [details]
Patch
Comment 3 WebKit Review Bot 2012-02-28 11:56:50 PST
Comment on attachment 129300 [details]
Patch

Attachment 129300 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11709034
Comment 4 Jer Noble 2012-02-28 13:29:12 PST
Created attachment 129317 [details]
Patch
Comment 5 Jer Noble 2012-02-28 13:33:06 PST
Created attachment 129319 [details]
Patch

Added missing break statement in CSSPrimitiveValueMappings.h
Comment 6 Jer Noble 2012-02-28 13:47:08 PST
Created attachment 129323 [details]
Patch

Rebaselined.
Comment 7 WebKit Review Bot 2012-02-28 14:26:07 PST
Comment on attachment 129323 [details]
Patch

Attachment 129323 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11711110
Comment 8 Jer Noble 2012-02-28 16:12:17 PST
Created attachment 129349 [details]
Patch

Fullscreen -> FullScreen in all cases.
Comment 9 Jer Noble 2012-02-28 16:52:02 PST
Created attachment 129355 [details]
Patch

Update WKSI to latest version (fixing mac compilation error).
Comment 10 Eric Carlson 2012-02-29 09:52:57 PST
Comment on attachment 129355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129355&action=review

> Source/WebCore/rendering/RenderThemeMac.h:161
> +    virtual bool paintMediaFullScreenVolumeSliderTrack(RenderObject*, const PaintInfo&, const IntRect&);
> +    virtual bool paintMediaFullScreenVolumeSliderThumb(RenderObject*, const PaintInfo&, const IntRect&);

The new WebKit hottness is to mark virtual overrides with OVERRIDE. All the cool kids are doing it, you should too!
Comment 11 Jer Noble 2012-02-29 10:55:26 PST
Committed r109231: <http://trac.webkit.org/changeset/109231>