Bug 79807 - Extended attributes list should go before 'static' and 'const' modifiers in IDLs.
Summary: Extended attributes list should go before 'static' and 'const' modifiers in I...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pavel Podivilov
Depends on:
Reported: 2012-02-28 09:22 PST by Pavel Podivilov
Modified: 2012-02-29 07:24 PST (History)
5 users (show)

See Also:

Patch (11.26 KB, patch)
2012-02-28 09:24 PST, Pavel Podivilov
haraken: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2012-02-28 09:22:36 PST
Currently 'static' and 'const' are placed before extended attributes which is a syntax error.

Comment 1 Pavel Podivilov 2012-02-28 09:24:04 PST
Created attachment 129278 [details]
Comment 2 Kentaro Hara 2012-02-28 15:41:59 PST
Comment on attachment 129278 [details]

OK. Thanks for the patch!
Comment 3 WebKit Review Bot 2012-02-29 01:24:31 PST
The commit-queue encountered the following flaky tests while processing attachment 129278 [details]:

fast/dom/error-to-string-stack-overflow.html bug 79894 (authors: ager@chromium.org and arv@chromium.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Review Bot 2012-02-29 01:25:40 PST
Comment on attachment 129278 [details]

Rejecting attachment 129278 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
CT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 [Refactoring] Shadow related attach paths should be in ShadowTree.

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/11746103
Comment 5 Pavel Podivilov 2012-02-29 07:24:40 PST
Committed r109210: <http://trac.webkit.org/changeset/109210>