Bug 79801 - Refactor SpeculativeJIT::emitAllocateJSFinalObject
Summary: Refactor SpeculativeJIT::emitAllocateJSFinalObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-28 08:49 PST by Mark Hahnenberg
Modified: 2012-02-28 22:28 PST (History)
2 users (show)

See Also:


Attachments
Patch (3.92 KB, patch)
2012-02-28 18:54 PST, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-02-28 08:49:34 PST
Currently in the DFG we only support inline allocation for JSFinalObjects. We should refactor this code slightly in such a way that it is easier to allocate various other types of objects (e.g. JSArray, JSFunction, etc.), similar to how we currently do things in the baseline JIT.
Comment 1 Mark Hahnenberg 2012-02-28 18:54:42 PST
Created attachment 129375 [details]
Patch
Comment 2 Filip Pizlo 2012-02-28 20:34:22 PST
Comment on attachment 129375 [details]
Patch

r=me.
Comment 3 WebKit Review Bot 2012-02-28 22:28:46 PST
Comment on attachment 129375 [details]
Patch

Clearing flags on attachment: 129375

Committed r109194: <http://trac.webkit.org/changeset/109194>
Comment 4 WebKit Review Bot 2012-02-28 22:28:50 PST
All reviewed patches have been landed.  Closing bug.