Bug 79799 - webkit-patch can't find bug numbers from ChangeLog entries that use wkb.ug URLs
Summary: webkit-patch can't find bug numbers from ChangeLog entries that use wkb.ug URLs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on: 79806
Blocks:
  Show dependency tree / graph
 
Reported: 2012-02-28 08:40 PST by Adam Roben (:aroben)
Modified: 2012-02-28 09:13 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.89 KB, patch)
2012-02-28 08:40 PST, Adam Roben (:aroben) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2012-02-28 08:40:25 PST 
webkit-patch can't find bug numbers from ChangeLog entries that use wkb.ug URLs
Comment 1 Adam Roben (:aroben) 2012-02-28 08:40:58 PST 
Created attachment 129262 [details]
Patch
Comment 2 Adam Roben (:aroben) 2012-02-28 08:49:52 PST 
Committed r109110: <http://trac.webkit.org/changeset/109110>
Comment 3 mitz 2012-02-28 08:52:35 PST 
I don't think it's good to have this link format in change logs. Why make it easier to do so?
Comment 4 Adam Roben (:aroben) 2012-02-28 08:54:44 PST 
(In reply to comment #3)
> I don't think it's good to have this link format in change logs. Why make it easier to do so?

I added it for consistency with our support for http://webkit.org/b/NNNNN. Do you think that format also doesn't belong in ChangeLogs?
Comment 5 mitz 2012-02-28 09:01:29 PST 
(In reply to comment #4)
> (In reply to comment #3)
> > I don't think it's good to have this link format in change logs. Why make it easier to do so?
> 
> I added it for consistency with our support for http://webkit.org/b/NNNNN. Do you think that format also doesn't belong in ChangeLogs?

I think that format is fine. It's in the same high-level domain as the bug database itself (webkit.org).
Comment 6 Adam Roben (:aroben) 2012-02-28 09:10:57 PST 
OK, I'll roll this out.