WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
79792
Web Inspector: preserve memory counters size after frontend reopening
https://bugs.webkit.org/show_bug.cgi?id=79792
Summary
Web Inspector: preserve memory counters size after frontend reopening
Yury Semikhatsky
Reported
2012-02-28 07:38:41 PST
The size should be restored.
Attachments
Patch
(4.35 KB, patch)
2012-02-28 07:40 PST
,
Yury Semikhatsky
pfeldman
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1
2012-02-28 07:40:41 PST
Created
attachment 129253
[details]
Patch
Pavel Feldman
Comment 2
2012-02-28 08:12:13 PST
Comment on
attachment 129253
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=129253&action=review
> Source/WebCore/inspector/front-end/TimelinePanel.js:66 > + WebInspector.settings.memoryCounterGraphsHeight = WebInspector.settings.createSetting("memoryCounterGraphsHeight", 600);
Inspector's default height is 600, this should be 150.
> Source/WebCore/inspector/front-end/TimelinePanel.js:175 > + WebInspector.settings.memoryCounterGraphsHeight.set(top);
this should be a part of _endSplitterDragging.
Yury Semikhatsky
Comment 3
2012-02-28 08:22:00 PST
(In reply to
comment #2
)
> (From update of
attachment 129253
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=129253&action=review
> > > Source/WebCore/inspector/front-end/TimelinePanel.js:66 > > + WebInspector.settings.memoryCounterGraphsHeight = WebInspector.settings.createSetting("memoryCounterGraphsHeight", 600); > > Inspector's default height is 600, this should be 150. >
Done.
> > Source/WebCore/inspector/front-end/TimelinePanel.js:175 > > + WebInspector.settings.memoryCounterGraphsHeight.set(top); > > this should be a part of _endSplitterDragging.
Done.
Yury Semikhatsky
Comment 4
2012-02-28 08:27:56 PST
Committed
r109109
: <
http://trac.webkit.org/changeset/109109
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug