Bug 79792 - Web Inspector: preserve memory counters size after frontend reopening
Summary: Web Inspector: preserve memory counters size after frontend reopening
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-28 07:38 PST by Yury Semikhatsky
Modified: 2012-02-28 08:27 PST (History)
10 users (show)

See Also:

Attachments
Patch (4.35 KB, patch)
2012-02-28 07:40 PST, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-02-28 07:38:41 PST 
The size should be restored.
Comment 1 Yury Semikhatsky 2012-02-28 07:40:41 PST 
Created attachment 129253 [details]
Patch
Comment 2 Pavel Feldman 2012-02-28 08:12:13 PST 
Comment on attachment 129253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129253&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:66
> +        WebInspector.settings.memoryCounterGraphsHeight = WebInspector.settings.createSetting("memoryCounterGraphsHeight", 600);

Inspector's default height is 600, this should be 150.

> Source/WebCore/inspector/front-end/TimelinePanel.js:175
> +        WebInspector.settings.memoryCounterGraphsHeight.set(top);

this should be a part of _endSplitterDragging.
Comment 3 Yury Semikhatsky 2012-02-28 08:22:00 PST 
(In reply to comment #2)
> (From update of attachment 129253 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=129253&action=review
> 
> > Source/WebCore/inspector/front-end/TimelinePanel.js:66
> > +        WebInspector.settings.memoryCounterGraphsHeight = WebInspector.settings.createSetting("memoryCounterGraphsHeight", 600);
> 
> Inspector's default height is 600, this should be 150.
> 
Done.

> > Source/WebCore/inspector/front-end/TimelinePanel.js:175
> > +        WebInspector.settings.memoryCounterGraphsHeight.set(top);
> 
> this should be a part of _endSplitterDragging.
Done.
Comment 4 Yury Semikhatsky 2012-02-28 08:27:56 PST 
Committed r109109: <http://trac.webkit.org/changeset/109109>