Created attachment 129249 [details] Screenshot showing default rendering of track subtitles, though mode set to TextTrack.HIDDEN Simple example: http://html5-demos.appspot.com/static/video/track Expected behaviour: default subtitles should not be rendered: var track = video.textTracks[0]; track.mode = TextTrack.HIDDEN; What actually happens: subtitles rendered over video. Likewise, in track.js on http://www.samdutton.com/track I attempt to set the mode of the metadata track to 1 (TextTrack.HIDDEN). This is the track used for the text in the right hand box. Also doesn't work from Chrome Dev Tools. Try the following from the Dev Tools console: document.querySelector("video").textTracks[1].mode = TextTrack.HIDDEN According to the spec, it should be possible to change the text track mode: http://dev.w3.org/html5/spec/video.html#texttrack. (BTW: I'm pretty sure setting mode worked OK in Chrome ??18.) See also http://code.google.com/p/chromium/issues/detail?id=113413
I believe the problem is that when the mode is set, m_showingByDefault remains true, when really it should be set to false. Patch coming shortly.
Created attachment 135231 [details] fixes problem, needs tests
This change looks OK, but we should have the test in the same patch.
Created attachment 135405 [details] including tests
Comment on attachment 135405 [details] including tests View in context: https://bugs.webkit.org/attachment.cgi?id=135405&action=review > LayoutTests/media/track/track-mode.html:16 > + Nit: this blank line is unnecessary.
Created attachment 135436 [details] Patch for landing
Comment on attachment 135436 [details] Patch for landing Rejecting attachment 135436 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12317525
Created attachment 135450 [details] Patch for landing
Comment on attachment 135450 [details] Patch for landing Clearing flags on attachment: 135450 Committed r113110: <http://trac.webkit.org/changeset/113110>
All reviewed patches have been landed. Closing bug.