The same way we ignore load events and progress, resources should be ignored too.
Created attachment 129229 [details] Patch
Comment on attachment 129229 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129229&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:891 > + if (priv->replaceContentStatus == ReplacingContent || priv->replaceContentStatus == DidReplaceContent) > + return 0; I see this code used in 4 places. Can it be moved to a function?
(In reply to comment #2) > (From update of attachment 129229 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=129229&action=review > > > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:891 > > + if (priv->replaceContentStatus == ReplacingContent || priv->replaceContentStatus == DidReplaceContent) > > + return 0; > > I see this code used in 4 places. Can it be moved to a function? Sure!
Created attachment 132104 [details] Updated patch Rebased to apply on current git master and added helper function as phil suggested.
Patches blocking this bug landed already.
Comment on attachment 132104 [details] Updated patch Alright, looks good to me! Sorry for the review delay :(
(In reply to comment #6) > (From update of attachment 132104 [details]) > Alright, looks good to me! Sorry for the review delay :( No problem, thanks for reviewing :-)
Committed r114719: <http://trac.webkit.org/changeset/114719>