The implementation of GC3DPrivate has splited into three patches in order to keep it simple and short. 1. Bug 62961 is the initial implementation including simple functions which only call GL functions through Evas_GL_API. 2. This patch contains the implementation of a little complicated functions such as getActiveAttrib(), getShaderSource() and so on. 3. The last patch for GC3DPrivate is going to include initialization and destruction using Evas_GL APIs.
Created attachment 129204 [details] Patch
Comment on attachment 129204 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129204&action=review LGTM, except a couple of nitpicks - please fix before committing. > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:434 > + if (m_syntheticErrors.size() > 0) { Use .isEmpty() > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:463 > + *value /= 4; Comment for why this is /4
Created attachment 129380 [details] modified patch
(In reply to comment #2) > (From update of attachment 129204 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=129204&action=review > LGTM, except a couple of nitpicks - please fix before committing. > > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:434 > > + if (m_syntheticErrors.size() > 0) { > Use .isEmpty() > > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:463 > > + *value /= 4; > Comment for why this is /4 It's a really important finding! I was a little confused about OpenGL ES 2 compliance. Evas_GL offers the OpenGL ES 2 interface, so I removed codes for desktop-GL in getIntegerv() like GraphicsContext3DOpenGLES.cpp. Please review this modification again. Thanks.
Comment on attachment 129380 [details] modified patch LGTM, please have one of the EFL committers set the cq flag.
Comment on attachment 129380 [details] modified patch Clearing flags on attachment: 129380 Committed r109694: <http://trac.webkit.org/changeset/109694>
All reviewed patches have been landed. Closing bug.