Bug 79753 - RuntimeEnabledFeatures::setMultipleShadowSubtreesEnabled should not be inline
Summary: RuntimeEnabledFeatures::setMultipleShadowSubtreesEnabled should not be inline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Normal
Assignee: Roland Steiner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-27 23:46 PST by Roland Steiner
Modified: 2012-02-28 02:19 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.44 KB, patch)
2012-02-27 23:49 PST, Roland Steiner 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2012-02-27 23:46:34 PST 
It's referred in WebCore.exp.in if SHADOW_DOM is enabled, and creates a linker error if inline
Comment 1 Roland Steiner 2012-02-27 23:49:24 PST 
Created attachment 129199 [details]
Patch
Comment 2 Hayato Ito 2012-02-28 00:07:26 PST 
Looks reasonable.
Inline should be avoided here because it is used from DumpRenderTree.
Comment 3 Hajime Morrita 2012-02-28 00:18:16 PST 
Comment on attachment 129199 [details]
Patch

Basically we should inline runtime feature accessor for performance reason. But considering this flag will be removed shortly, this is OK for now.
Comment 4 WebKit Review Bot 2012-02-28 01:24:00 PST 
Comment on attachment 129199 [details]
Patch

Clearing flags on attachment: 129199

Committed r109089: <http://trac.webkit.org/changeset/109089>
Comment 5 WebKit Review Bot 2012-02-28 01:24:05 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2012-02-28 02:19:45 PST 
The commit-queue encountered the following flaky tests while processing attachment 129199 [details]:

compositing/reflections/nested-reflection-transformed2.html bug 79743 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.