Bug 79745 – [ShadowDOM] Replace createDom and createShadow function in LayoutTests/fast/dom/shadow/create-dom.js with more flexible one

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Hayato Ito]

This is a separated, but independent, patch from https://bugs.webkit.org/show_bug.cgi?id=79197.

We need to improve createDom and createShadow function defined in LayoutTests/fast/dom/shadow/create-dom.js because:
  - createShadow is confusing name. It actually creates ShadowHost and ShadowRoot at the same time.
  - createDom should be named createDOM since WebKit doesn't use CamelCase for abbreviation.
  - It might be better that we can create lightChildren and ShadowRoot for an element at the same time in one expression. This is impossible in the current implementation.

[Hayato Ito]

Created attachment 129191 [details]
rewrite createDOM

[WebKit Review Bot]

Comment on attachment 129191 [details]
rewrite createDOM

Clearing flags on attachment: 129191

Committed r109191: <http://trac.webkit.org/changeset/109191>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Dimitri Glazkov (Google)]

Comment on attachment 129191 [details]
rewrite createDOM

View in context: https://bugs.webkit.org/attachment.cgi?id=129191&action=review

> LayoutTests/fast/dom/shadow/resources/create-dom.js:21
> +              shadowRoot = new internals.ensureShadowRoot(element);

This typo is making the tests fail on platforms that don't have SHADOW_ROOT enabled. Shouldn't have "new".

[Hayato Ito]

Ops. My bad. I should have tested this patch on platforms which don't have SHADOW_ROOT enabled.

(In reply to comment #4)
> (From update of attachment 129191 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=129191&action=review
> 
> > LayoutTests/fast/dom/shadow/resources/create-dom.js:21
> > +              shadowRoot = new internals.ensureShadowRoot(element);
> 
> This typo is making the tests fail on platforms that don't have SHADOW_ROOT enabled. Shouldn't have "new".