Bug 79742 - Add missing parameter to didCreateScriptContext() so it overrides base class again.
Summary: Add missing parameter to didCreateScriptContext() so it overrides base class ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Kozianski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-27 21:35 PST by James Kozianski
Modified: 2012-02-27 22:34 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.72 KB, patch)
2012-02-27 21:35 PST, James Kozianski
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Kozianski 2012-02-27 21:35:03 PST
Add missing parameter to didCreateScriptContext() so it overrides base class again.
Comment 1 James Kozianski 2012-02-27 21:35:42 PST
Created attachment 129184 [details]
Patch
Comment 2 Kenichi Ishibashi 2012-02-27 21:39:59 PST
Kent-san, could you review the patch? This should fix WebFrameTest failures.
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6/builds/12819/steps/webkit_unit_tests/logs/stdio
Comment 3 Kent Tamura 2012-02-27 21:45:02 PST
Comment on attachment 129184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129184&action=review

ok

> Source/WebKit/chromium/ChangeLog:7
> +

We had better explain that http://trac.webkit.org/changeset/109064 added the parameter.
Comment 4 WebKit Review Bot 2012-02-27 22:34:26 PST
Comment on attachment 129184 [details]
Patch

Clearing flags on attachment: 129184

Committed r109078: <http://trac.webkit.org/changeset/109078>
Comment 5 WebKit Review Bot 2012-02-27 22:34:30 PST
All reviewed patches have been landed.  Closing bug.