Bug 7974 - Add EditActions and WebUndoActions for CreateLink and Unlink
Summary: Add EditActions and WebUndoActions for CreateLink and Unlink
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Justin Garcia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-25 01:48 PST by Justin Garcia
Modified: 2006-03-27 00:31 PST (History)
0 users

See Also:

Attachments
patch (3.60 KB, patch)
2006-03-26 19:26 PST, Justin Garcia 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Garcia 2006-03-25 01:48:45 PST 
So that something appropriate will appear next to Undo in the edit menu for these.
Comment 1 Justin Garcia 2006-03-26 19:26:49 PST 
Created attachment 7319 [details]
patch

We might want to use "Undo Remove Link" instead of "Undo Unlink" because "Remove Link" might be easier to localize.  On the other hand we use "Undo Unscript" for the operation that removes subscript/superscripting from the selection.  Also, "Remove Link" isn't really correct because the operation will remove _all_ links inside the selection.
Comment 2 Justin Garcia 2006-03-26 19:35:15 PST 
> Also, "Remove Link" isn't really correct because the operation will
> remove _all_ links inside the selection.

So then the decision is between "Unlink" and "Remove Link(s)".
Comment 3 Darin Adler 2006-03-26 22:51:19 PST 
Comment on attachment 7319 [details]
patch

r=me