WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
79721
Repair license blocks for files created during modularization
https://bugs.webkit.org/show_bug.cgi?id=79721
Summary
Repair license blocks for files created during modularization
Adam Barth
Reported
2012-02-27 17:11:46 PST
Repair license blocks for files created during modularization
Attachments
Patch
(19.29 KB, patch)
2012-02-27 17:14 PST
,
Adam Barth
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2012-02-27 17:14:43 PST
Created
attachment 129142
[details]
Patch
Eric Seidel (no email)
Comment 2
2012-02-27 17:25:23 PST
Seems like something scripts should monitor instead of humans. Humans are bad at this kind of thing.
Alexey Proskuryakov
Comment 3
2012-02-27 17:27:16 PST
Comment on
attachment 129142
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=129142&action=review
> Source/WebCore/Modules/geolocation/NavigatorGeolocation.h:2 > + Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
This is weird, but I guess OK to move as is.
> Source/WebCore/Modules/mediastream/NavigatorMediaStream.cpp:6 > + * Copyright (C) 2000 Harri Porten (
porten@kde.org
) > + * Copyright (c) 2000 Daniel Molkentin (
molkentin@kde.org
) > + * Copyright (c) 2000 Stefan Schimanski (
schimmi@kde.org
) > + * Copyright (C) 2003, 2004, 2005, 2006 Apple Computer, Inc. > + * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
Ditto.
> Source/WebCore/Modules/mediastream/NavigatorMediaStream.h:2 > + Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
Ditto.
> Source/WebCore/bindings/js/JSDOMWindowWebAudioCustom.cpp:2 > + * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
I don't think Apple contributed code to this in these years.
> Source/WebCore/bindings/js/JSDOMWindowWebAudioCustom.cpp:20 > - > +
Extra space.
> Source/WebCore/bindings/js/JSDOMWindowWebSocketCustom.cpp:3 > + * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. > * Copyright (C) 2011 Google Inc. All rights reserved.
I don't know if Apple contributed to this file (not in 2007 for sure).
> Source/WebCore/bindings/js/JSDOMWindowWebSocketCustom.cpp:20 > - > +
Extra space.
Adam Barth
Comment 4
2012-02-27 17:31:17 PST
I just copied the license blocks from the files that previously contained these chunks of code. I don't particularly know (or care) who contributed what to where in which year.
Adam Barth
Comment 5
2012-02-27 17:36:29 PST
Committed
r109052
: <
http://trac.webkit.org/changeset/109052
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug