Bug 79712 – Clipboard::getData should return an empty string instead of undefined

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Daniel Cheng]

Clipboard::getData should return an empty string instead of undefined

[Daniel Cheng]

Created attachment 129126 [details]
Patch

[Daniel Cheng]

Are we planning on importing more IETC tests? This is covered by http://samples.msdn.microsoft.com/ietestcenter/html5/dragdrop/getData_dragenter.htm.

Otherwise I'll just write a new layout test for this.

[Adam Barth]

You can either import the IETC test or write a new test.  Whatever is more convenient for you.

[Eric Seidel (no email)]

In the past I've found it easier to write a new test.  Most of the IETC tests are not designed for automated testing.

[Eric Seidel (no email)]

Comment on attachment 129126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129126&action=review

> Source/WebCore/ChangeLog:10
> +        No new tests. (OOPS!)

This will cause the CQ to fail, you'll need to replace this line with a list of tests your'e changing/adding.

[Daniel Cheng]

Created attachment 129149 [details]
Patch

[Tony Chang]

Comment on attachment 129149 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129149&action=review

It seems unfortunate that you can't tell if something is in the clipboard or just an empty string, but maybe that's intentional.

What does Firefox do?

> Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:452
> +    if (!getWebLocData(dataObject, url, title)) {

Nit: Can we early return here instead of nesting?

[Daniel Cheng]

(In reply to comment #7)
> (From update of attachment 129149 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=129149&action=review
> 
> It seems unfortunate that you can't tell if something is in the clipboard or just an empty string, but maybe that's intentional.
> 
> What does Firefox do?
> 

My test shows they return empty strings instead of undefined.

> > Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:452
> > +    if (!getWebLocData(dataObject, url, title)) {
> 
> Nit: Can we early return here instead of nesting?

Done.

[Daniel Cheng]

Committed r109176: <http://trac.webkit.org/changeset/109176>