WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
79712
Clipboard::getData should return an empty string instead of undefined
https://bugs.webkit.org/show_bug.cgi?id=79712
Summary
Clipboard::getData should return an empty string instead of undefined
Daniel Cheng
Reported
2012-02-27 16:10:38 PST
Clipboard::getData should return an empty string instead of undefined
Attachments
Patch
(30.73 KB, patch)
2012-02-27 16:35 PST
,
Daniel Cheng
no flags
Details
Formatted Diff
Diff
Patch
(36.00 KB, patch)
2012-02-27 17:43 PST
,
Daniel Cheng
tony
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Daniel Cheng
Comment 1
2012-02-27 16:35:13 PST
Created
attachment 129126
[details]
Patch
Daniel Cheng
Comment 2
2012-02-27 16:36:38 PST
Are we planning on importing more IETC tests? This is covered by
http://samples.msdn.microsoft.com/ietestcenter/html5/dragdrop/getData_dragenter.htm
. Otherwise I'll just write a new layout test for this.
Adam Barth
Comment 3
2012-02-27 16:38:16 PST
You can either import the IETC test or write a new test. Whatever is more convenient for you.
Eric Seidel (no email)
Comment 4
2012-02-27 16:58:26 PST
In the past I've found it easier to write a new test. Most of the IETC tests are not designed for automated testing.
Eric Seidel (no email)
Comment 5
2012-02-27 16:59:28 PST
Comment on
attachment 129126
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=129126&action=review
> Source/WebCore/ChangeLog:10 > + No new tests. (OOPS!)
This will cause the CQ to fail, you'll need to replace this line with a list of tests your'e changing/adding.
Daniel Cheng
Comment 6
2012-02-27 17:43:15 PST
Created
attachment 129149
[details]
Patch
Tony Chang
Comment 7
2012-02-28 14:36:08 PST
Comment on
attachment 129149
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=129149&action=review
It seems unfortunate that you can't tell if something is in the clipboard or just an empty string, but maybe that's intentional. What does Firefox do?
> Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:452 > + if (!getWebLocData(dataObject, url, title)) {
Nit: Can we early return here instead of nesting?
Daniel Cheng
Comment 8
2012-02-28 17:29:19 PST
(In reply to
comment #7
)
> (From update of
attachment 129149
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=129149&action=review
> > It seems unfortunate that you can't tell if something is in the clipboard or just an empty string, but maybe that's intentional. > > What does Firefox do? >
My test shows they return empty strings instead of undefined.
> > Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:452 > > + if (!getWebLocData(dataObject, url, title)) { > > Nit: Can we early return here instead of nesting?
Done.
Daniel Cheng
Comment 9
2012-02-28 17:32:07 PST
Committed
r109176
: <
http://trac.webkit.org/changeset/109176
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug