...
Created attachment 129116 [details] proposed patch This has been previously discussed on plugin-futures, adding an experimental implementation to validate the approach.
Attachment 129116 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 129141 [details] style fix, and added a comment
Attachment 129141 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 129141 [details] style fix, and added a comment Attachment 129141 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11645287
Comment on attachment 129141 [details] style fix, and added a comment View in context: https://bugs.webkit.org/attachment.cgi?id=129141&action=review This seems to have problems building. > Source/WebKit2/ChangeLog:10 > + * PluginProcess/mac/plugin.sb: Added. The sandbox profile for the WebProcess is called, com.apple.WebProcess.sb. Should we match the naming convention? Also, is it possible/a good idea to extract a set of both profiles that are common and share them?
> This seems to have problems building. Fixed a non-Mac issue locally, but mostly it depends on WKSI changes that are yet to be landed. > The sandbox profile for the WebProcess is called, com.apple.WebProcess.sb. Should we match the naming convention? I don't really care, I liked plugin.sb. > Also, is it possible/a good idea to extract a set of both profiles that are common and share them? I think that at this stage, it's easier to maintain them separately.
Comment on attachment 129141 [details] style fix, and added a comment I think plugin.sb should be com.apple.PluginProcess.sb to match the WebProcess name.
Created attachment 129311 [details] patch for landing
Comment on attachment 129311 [details] patch for landing Rejecting attachment 129311 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Ander Carlsson found in /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11714047
Created attachment 129313 [details] patch for landing
Comment on attachment 129313 [details] patch for landing Clearing flags on attachment: 129313 Committed r109143: <http://trac.webkit.org/changeset/109143>
All reviewed patches have been landed. Closing bug.
Build fix in <http://trac.webkit.org/changeset/109148>.
Reopening to attach new patch.
Created attachment 129330 [details] Patch It looks like this has broken qt buildbots. The following patch is a build fix, please double check it before landing.
Build fix has already been landed, please see above.
Comment on attachment 129330 [details] Patch -#if PLATFORM(MAC) && !defined(BUILDING_ON_LEOPARD) || !defined(BUILDING_ON_SNOW_LEOPARD) +#if PLATFORM(MAC) && (!defined(BUILDING_ON_LEOPARD) || !defined(BUILDING_ON_SNOW_LEOPARD)) Also, this is insufficient, there are two instances of this in this file.
Mac build fix of same kind in <http://trac.webkit.org/changeset/109159>.