RESOLVED FIXED79697
Move WebCore-internal DOM notification methods from Node to ContainerNode where appropriate 
https://bugs.webkit.org/show_bug.cgi?id=79697
Summary Move WebCore-internal DOM notification methods from Node to ContainerNode whe...
Adam Klein
Reported 2012-02-27 13:53:36 PST
Move WebCore-internal DOM notification methods from Node to ContainerNode where appropriate
Attachments
Patch (9.00 KB, patch)
2012-02-27 14:01 PST, Adam Klein 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Klein
Comment 1 2012-02-27 14:01:31 PST
Created attachment 129097 [details] Patch
Ryosuke Niwa
Comment 2 2012-02-27 14:06:57 PST
Comment on attachment 129097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129097&action=review > Source/WebCore/dom/ContainerNode.cpp:817 > for (Node* child = m_firstChild; child; child = child->nextSibling()) > - child->insertedIntoTree(true); > + if (child->isContainerNode()) > + toContainerNode(child)->insertedIntoTree(true); Nit: this for loop needs curly brackets now. > Source/WebCore/dom/ContainerNode.cpp:826 > for (Node* child = m_firstChild; child; child = child->nextSibling()) > - child->removedFromTree(true); > + if (child->isContainerNode()) > + toContainerNode(child)->removedFromTree(true); Ditto. > Source/WebCore/dom/ContainerNode.h:91 > + virtual void insertedIntoTree(bool deep); > + virtual void removedFromTree(bool deep); We should change these to enums (of course in a separate patch) :(
Adam Klein
Comment 3 2012-02-27 14:53:35 PST
Committed r109026: <http://trac.webkit.org/changeset/109026>
Note You need to log in before you can comment on or make changes to this bug.