Bug 79696 - Undefined variable 'current' when running chromium_android.py
Summary: Undefined variable 'current' when running chromium_android.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xianzhu Wang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-27 13:47 PST by Xianzhu Wang
Modified: 2012-02-27 17:30 PST (History)
3 users (show)

See Also:

Attachments
patch (1.20 KB, patch)
2012-02-27 13:59 PST, Xianzhu Wang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-02-27 13:47:44 PST 
Sorry I uploaded a wrong version of patch to bug 79506 which contains a typo. Will fix it asap.
Comment 1 Xianzhu Wang 2012-02-27 13:59:31 PST 
Created attachment 129095 [details]
patch
Comment 2 Adam Barth 2012-02-27 14:05:09 PST 
Comment on attachment 129095 [details]
patch

This is the point when I nag you about adding unit testing for this code.  This sort is bug is really easy to catch with a unit test.  I think it's ok to land this patch without a test, but at some point we'll probably want to add tests.
Comment 3 WebKit Review Bot 2012-02-27 17:28:22 PST 
The commit-queue encountered the following flaky tests while processing attachment 129095 [details]:

css3/filters/effect-invert-hw.html bug 79639 (author: cmarrin@apple.com)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Review Bot 2012-02-27 17:30:23 PST 
Comment on attachment 129095 [details]
patch

Clearing flags on attachment: 129095

Committed r109049: <http://trac.webkit.org/changeset/109049>
Comment 5 WebKit Review Bot 2012-02-27 17:30:27 PST 
All reviewed patches have been landed.  Closing bug.