WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
79696
Undefined variable 'current' when running chromium_android.py
https://bugs.webkit.org/show_bug.cgi?id=79696
Summary
Undefined variable 'current' when running chromium_android.py
Xianzhu Wang
Reported
2012-02-27 13:47:44 PST
Sorry I uploaded a wrong version of patch to
bug 79506
which contains a typo. Will fix it asap.
Attachments
patch
(1.20 KB, patch)
2012-02-27 13:59 PST
,
Xianzhu Wang
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Xianzhu Wang
Comment 1
2012-02-27 13:59:31 PST
Created
attachment 129095
[details]
patch
Adam Barth
Comment 2
2012-02-27 14:05:09 PST
Comment on
attachment 129095
[details]
patch This is the point when I nag you about adding unit testing for this code. This sort is bug is really easy to catch with a unit test. I think it's ok to land this patch without a test, but at some point we'll probably want to add tests.
WebKit Review Bot
Comment 3
2012-02-27 17:28:22 PST
The commit-queue encountered the following flaky tests while processing
attachment 129095
[details]
: css3/filters/effect-invert-hw.html
bug 79639
(author:
cmarrin@apple.com
) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 4
2012-02-27 17:30:23 PST
Comment on
attachment 129095
[details]
patch Clearing flags on attachment: 129095 Committed
r109049
: <
http://trac.webkit.org/changeset/109049
>
WebKit Review Bot
Comment 5
2012-02-27 17:30:27 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug