Bug 79691 - Web Inspector: [InspectorIndexedDB] Show meaningful description for object store items values.
Summary: Web Inspector: [InspectorIndexedDB] Show meaningful description for object st...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks: 75386
  Show dependency treegraph
 
Reported: 2012-02-27 12:02 PST by Vsevolod Vlasov
Modified: 2012-03-02 02:00 PST (History)
10 users (show)

See Also:


Attachments
Patch (4.90 KB, patch)
2012-02-27 12:03 PST, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (8.19 KB, patch)
2012-03-01 12:41 PST, Vsevolod Vlasov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-02-27 12:02:17 PST
Show meaningful description for object store items values.
Comment 1 Vsevolod Vlasov 2012-02-27 12:03:41 PST
Created attachment 129081 [details]
Patch
Comment 2 Pavel Feldman 2012-02-28 09:51:28 PST
Comment on attachment 129081 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129081&action=review

> Source/WebCore/inspector/front-end/IndexedDBViews.js:349
> +            span.appendChild(document.createTextNode("\"" + value.description + "\""));

Appending blob will kill the renderer.

> Source/WebCore/inspector/front-end/IndexedDBViews.js:352
> +        default:

What about the number, null, undefined?
Comment 3 Vsevolod Vlasov 2012-03-01 12:41:53 PST
Created attachment 129733 [details]
Patch
Comment 4 Vsevolod Vlasov 2012-03-02 02:00:19 PST
Committed r109536: <http://trac.webkit.org/changeset/109536>