79690 – Cleanup Gesture requirement when exiting video-play-require-user-gesture test

Bug 79690 - Cleanup Gesture requirement when exiting video-play-require-user-gesture test

Summary: Cleanup Gesture requirement when exiting video-play-require-user-gesture test

Attachments
Patch (2.39 KB, patch) 2012-02-27 11:56 PST, Min Qin	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Min Qin 2012-02-27 11:56:08 PST

Cleanup Gesture requirement when exiting video-play-require-user-gesture test

Comment 1 Min Qin 2012-02-27 11:56:47 PST

Created attachment 129079 [details]
Patch

Comment 2 Philippe Normand 2012-02-27 12:06:56 PST

Is this the cause of the flakiness? I didn't check your whole patch introducing this test, it was just a hunch I had.

Comment 3 Min Qin 2012-02-27 12:10:22 PST

Seems so, tested it with chromium. 
The chromium bot sometimes got 1-2 flaky test with my test html. But with this change, the flakiness is gone.

Comment 4 Philippe Normand 2012-02-27 12:19:54 PST

Comment on attachment 129079 [details]
Patch

Looks good, thanks!

Comment 5 WebKit Review Bot 2012-02-27 13:11:09 PST

Comment on attachment 129079 [details]
Patch

Clearing flags on attachment: 129079

Committed r109018: <http://trac.webkit.org/changeset/109018>

Comment 6 WebKit Review Bot 2012-02-27 13:11:14 PST

All reviewed patches have been landed.  Closing bug.

Comment 7 Philippe Normand 2012-02-27 13:54:57 PST

Media flakiness indeed went away thanks to this patch. Thanks :)

Comment 8 Min Qin 2012-02-27 14:11:15 PST

Thank you for finding out this problem, and for your hunch!