Bug 79684 – Web Inspector: move record formatting into the timeline presentation model.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 129069 [details]
Patch

[Andrey Kosyakov]

Comment on attachment 129069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129069&action=review

> Source/WebCore/inspector/front-end/TimelineModel.js:-173
> -        this.stopRecord();

So what happens when we load a file during record?

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:195
> +WebInspector.TimelinePresentationModel.Record = function(presentationModel, record, parentRecord, linkifier, scriptDetails)

Now that linkifier is in PresentationModel, we don't have to pass it as a separate patameter

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:509
> +    this._contentTable = document.createElement("table");;

one ;; should be enough

[Andrey Kosyakov]

Comment on attachment 129069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129069&action=review

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:178
> +        function updateBoundaries(record)

I think it's worth of a comment (or explicit return false)

> Source/WebCore/inspector/front-end/TimelinePanel.js:896
> +        return {left: left, width: width, widthWithChildren: widthWithChildren, cpuWidth: cpuWidth};

This could at least appear in the ChangeLog

[Vsevolod Vlasov]

Comment on attachment 129069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129069&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:461
> +                 this._glueParentButton.toggled &&

indent?

> Source/WebCore/inspector/front-end/TimelinePanel.js:466
> +            var newParentRecord = this._presentationModel._findParentRecord(record);

private?

[Pavel Feldman]

Created attachment 129070 [details]
Patch

[Pavel Feldman]

Created attachment 129071 [details]
Patch

[Pavel Feldman]

Committed r109009: <http://trac.webkit.org/changeset/109009>