Bug 79677 – Lexer: Specialize character predicates for LChar, UChar

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Andy Wingo]

The patch to be attached specializes some character predicates in the lexer for LChar vs UChar.

[Andy Wingo]

Created attachment 129055 [details]
Patch

[Andy Wingo]

Adding reviewers.  For speed tests, I used this:

$ time echo  'for (var i=0; i<1000; i++) checkSyntax("tests/parse-only/concat-jquery-mootools-prototype.js");' | /home/wingo/src/WebKit-trunk/WebKitBuild/Release/Programs/.libs/lt-jsc-3 /dev/stdin

real	0m6.290s
user	0m6.000s
sys	0m0.256s

$ time echo  'for (var i=0; i<1000; i++) checkSyntax("tests/parse-only/concat-jquery-mootools-prototype.js");' | /home/wingo/src/WebKit/WebKitBuild/Release/Programs/.libs/lt-jsc-3 /dev/stdin

real	0m6.141s
user	0m5.936s
sys	0m0.180s

That is to say, that I ran checkSyntax 1000 times in the same process on the larger file in the parse-only tests, and timed the whole run.  Here we see a reduction from 6.29 total seconds to 6.14 total seconds.  The times vary a bit, but they're about like this.

[Andy Wingo]

Created attachment 130089 [details]
fix unused param warning on mac

[Oliver Hunt]

Comment on attachment 130089 [details]
fix unused param warning on mac

r=me

[Andy Wingo]

Comment on attachment 130089 [details]
fix unused param warning on mac

Thanks!

[WebKit Review Bot]

Comment on attachment 130089 [details]
fix unused param warning on mac

Clearing flags on attachment: 130089

Committed r109769: <http://trac.webkit.org/changeset/109769>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.