WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
79675
Web Inspector: extract TimelineModel and TimelinePresentationModel into their own files.
https://bugs.webkit.org/show_bug.cgi?id=79675
Summary
Web Inspector: extract TimelineModel and TimelinePresentationModel into their...
Pavel Feldman
Reported
2012-02-27 08:29:06 PST
Patch to follow.
Attachments
Patch
(42.72 KB, patch)
2012-02-27 08:38 PST
,
Pavel Feldman
no flags
Details
Formatted Diff
Diff
Patch
(44.02 KB, patch)
2012-02-27 08:51 PST
,
Pavel Feldman
vsevik
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2012-02-27 08:38:54 PST
Created
attachment 129044
[details]
Patch
Andrey Kosyakov
Comment 2
2012-02-27 08:42:46 PST
Comment on
attachment 129044
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=129044&action=review
> Source/WebCore/inspector/front-end/TimelineModel.js:127 > + _loadFromFile: function(file)
So, where this is called from?
> Source/WebCore/inspector/front-end/TimelineModel.js:158 > + _saveToFile: function()
ditto.
> Source/WebCore/inspector/front-end/TimelineModel.js:171 > + _reset: function()
ditto.
Pavel Feldman
Comment 3
2012-02-27 08:51:48 PST
Created
attachment 129045
[details]
Patch
Andrey Kosyakov
Comment 4
2012-02-27 08:54:31 PST
Comment on
attachment 129045
[details]
Patch LGTM
Pavel Feldman
Comment 5
2012-02-27 08:58:28 PST
Committed
r108997
: <
http://trac.webkit.org/changeset/108997
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug