Bug 79675 - Web Inspector: extract TimelineModel and TimelinePresentationModel into their own files.
Summary: Web Inspector: extract TimelineModel and TimelinePresentationModel into their...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-27 08:29 PST by Pavel Feldman
Modified: 2012-02-27 08:58 PST (History)
10 users (show)

See Also:

Attachments
Patch (42.72 KB, patch)
2012-02-27 08:38 PST, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (44.02 KB, patch)
2012-02-27 08:51 PST, Pavel Feldman 		vsevik: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-02-27 08:29:06 PST 
Patch to follow.
Comment 1 Pavel Feldman 2012-02-27 08:38:54 PST 
Created attachment 129044 [details]
Patch
Comment 2 Andrey Kosyakov 2012-02-27 08:42:46 PST 
Comment on attachment 129044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=129044&action=review

> Source/WebCore/inspector/front-end/TimelineModel.js:127
> +    _loadFromFile: function(file)

So, where this is called from?

> Source/WebCore/inspector/front-end/TimelineModel.js:158
> +    _saveToFile: function()

ditto.

> Source/WebCore/inspector/front-end/TimelineModel.js:171
> +    _reset: function()

ditto.
Comment 3 Pavel Feldman 2012-02-27 08:51:48 PST 
Created attachment 129045 [details]
Patch
Comment 4 Andrey Kosyakov 2012-02-27 08:54:31 PST 
Comment on attachment 129045 [details]
Patch

LGTM
Comment 5 Pavel Feldman 2012-02-27 08:58:28 PST 
Committed r108997: <http://trac.webkit.org/changeset/108997>