Bug 79672 - Performance: stop recomputing SVG path data twice during layout
Summary: Performance: stop recomputing SVG path data twice during layout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-27 07:28 PST by Philip Rogers
Modified: 2012-02-27 09:58 PST (History)
4 users (show)

See Also:

Attachments
Stop recomputing SVG path data twice during layout (1.65 KB, patch)
2012-02-27 07:31 PST, Philip Rogers 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Rogers 2012-02-27 07:28:58 PST 
We currently recompute SVG path data twice during layout, but we only need to do this once. This is especially bad in the case of circles and ellipses, where each call to createShape() ends up creating 4 expensive cubics.

Patch forthcoming!
Comment 1 Philip Rogers 2012-02-27 07:31:07 PST 
Created attachment 129035 [details]
Stop recomputing SVG path data twice during layout
Comment 2 Nikolas Zimmermann 2012-02-27 08:54:05 PST 
Comment on attachment 129035 [details]
Stop recomputing SVG path data twice during layout

Nice catch, r=me.
Comment 3 WebKit Review Bot 2012-02-27 09:56:09 PST 
The commit-queue encountered the following flaky tests while processing attachment 129035 [details]:

css3/filters/effect-invert-hw.html bug 79639 (author: cmarrin@apple.com)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Review Bot 2012-02-27 09:58:09 PST 
Comment on attachment 129035 [details]
Stop recomputing SVG path data twice during layout

Clearing flags on attachment: 129035

Committed r109003: <http://trac.webkit.org/changeset/109003>
Comment 5 WebKit Review Bot 2012-02-27 09:58:13 PST 
All reviewed patches have been landed.  Closing bug.