Bug 79651 – [GTK] Crop support in BitmapImage

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKitGTK

[Philippe Normand]

I'm not sure it's doable already.

What I need to do when painting an Image surface from a source rectangle to a destination rectangle is to select only a region of the source rectangle.

I'll attach a patch for ImageCairo.

[Philippe Normand]

Created attachment 128991 [details]
Crop support in BitmapImage

[Martin Robinson]

Comment on attachment 128991 [details]
Crop support in BitmapImage

Is this used anywhere?

[Philippe Normand]

(In reply to comment #2)
> (From update of attachment 128991 [details])
> Is this used anywhere?

In the patch of bug 77087 :)
I'm not sure this is the right approach though, I did this as an experiment and it seems to work but my knowledge of the Cairo stuff is a bit limited.

[Philippe Normand]

Alex, what do you think about this?

[Martin Robinson]

(In reply to comment #4)
> Alex, what do you think about this?

Perhaps ::crop could me a method on ImageGstreamer. Then you could just adjust the srcRect you pass into Image::draw.

[Martin Robinson]

Comment on attachment 128991 [details]
Crop support in BitmapImage

I think perhaps platform-independent Image is the wrong place for this. :/ Also it seems like a change like this should just go in the patch that depends on it -- instead of introducing code that is totally dead. Perhaps we can chat about another design.

[Philippe Normand]

(In reply to comment #5)
> (In reply to comment #4)
> > Alex, what do you think about this?
> 
> Perhaps ::crop could me a method on ImageGstreamer. Then you could just adjust the srcRect you pass into Image::draw.

the rect in MediaPlayerPrivateGStreamer::paint() is the destination rectangle, I think. Not the source rectangle. What I need to crop is the source.

[Philippe Normand]

Will do as Martin suggests. Thanks!